Skip to content

Commit 4947925

Browse files
committed
made installations-exp depend on app-exp
1 parent 41cd275 commit 4947925

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

packages-exp/installations-exp/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
1616
"lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
1717
"build": "rollup -c",
18-
"build:deps": "lerna run --scope @firebase/'{app,installations-exp}' --include-dependencies build",
18+
"build:deps": "lerna run --scope @firebase/'{app-exp,installations-exp}' --include-dependencies build",
1919
"dev": "rollup -c -w",
2020
"test": "yarn type-check && yarn test:karma && yarn lint",
2121
"test:ci": "node ../../scripts/run_tests_in_ci.js",
@@ -45,8 +45,8 @@
4545
"typescript": "3.9.7"
4646
},
4747
"peerDependencies": {
48-
"@firebase/app": "0.x",
49-
"@firebase/app-types": "0.x"
48+
"@firebase/app-exp": "0.x",
49+
"@firebase/app-types-exp": "0.x"
5050
},
5151
"dependencies": {
5252
"@firebase/installations-types-exp": "0.1.0",

packages-exp/installations-exp/src/index.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
* limitations under the License.
1616
*/
1717

18-
import firebase from '@firebase/app';
19-
import {
20-
_FirebaseNamespace,
21-
FirebaseService
22-
} from '@firebase/app-types/private';
18+
// import firebase from '@firebase/app-exp';
19+
import { registerVersion, _registerComponent } from '@firebase/app-exp';
20+
import { _FirebaseService } from '@firebase/app-types-exp';
2321
import { Component, ComponentType } from '@firebase/component';
2422
import { FirebaseInstallations } from '@firebase/installations-types';
2523
import {
@@ -35,10 +33,10 @@ import { FirebaseDependencies } from './interfaces/firebase-dependencies';
3533

3634
import { name, version } from '../package.json';
3735

38-
export function registerInstallations(instance: _FirebaseNamespace): void {
36+
export function registerInstallations(): void {
3937
const installationsName = 'installations';
4038

41-
instance.INTERNAL.registerComponent(
39+
_registerComponent(
4240
new Component(
4341
installationsName,
4442
container => {
@@ -52,7 +50,7 @@ export function registerInstallations(instance: _FirebaseNamespace): void {
5250
platformLoggerProvider
5351
};
5452

55-
const installations: FirebaseInstallations & FirebaseService = {
53+
const installations: FirebaseInstallations & _FirebaseService = {
5654
app,
5755
getId: () => getId(dependencies),
5856
getToken: (forceRefresh?: boolean) =>
@@ -67,10 +65,10 @@ export function registerInstallations(instance: _FirebaseNamespace): void {
6765
)
6866
);
6967

70-
instance.registerVersion(name, version);
68+
registerVersion(name, version);
7169
}
7270

73-
registerInstallations(firebase as _FirebaseNamespace);
71+
registerInstallations();
7472

7573
/**
7674
* Define extension behavior of `registerInstallations`

0 commit comments

Comments
 (0)