Skip to content

Commit 4ad2e21

Browse files
maneeshtmansisampat
authored andcommitted
Revert "Fixed scroll behavior (#8977)" (#9053)
* Revert "Fixed scroll behavior (#9043)" This reverts commit 9bcd1ea. * Revert "Add Emulator Overlay (#8977) (#9031)" This reverts commit 8593fa0. * Undid revert of util * Create dirty-crews-cross.md * Removed unnecessary markdown file
1 parent 51d0703 commit 4ad2e21

File tree

5 files changed

+13
-17
lines changed

5 files changed

+13
-17
lines changed

.changeset/dirty-crews-cross.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@firebase/auth": patch
3+
"@firebase/database": patch
4+
"@firebase/firestore": patch
5+
"@firebase/functions": patch
6+
"@firebase/storage": patch
7+
---
8+
9+
Revert "Fixed scroll behavior (#9043)"

packages/auth/src/core/auth/emulator.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,7 @@ import { Auth } from '../../model/public_types';
1818
import { AuthErrorCode } from '../errors';
1919
import { _assert } from '../util/assert';
2020
import { _castAuth } from './auth_impl';
21-
import {
22-
deepEqual,
23-
isCloudWorkstation,
24-
pingServer,
25-
updateEmulatorBanner
26-
} from '@firebase/util';
21+
import { deepEqual, isCloudWorkstation, pingServer } from '@firebase/util';
2722

2823
/**
2924
* Changes the {@link Auth} instance to communicate with the Firebase Auth Emulator, instead of production

packages/database/src/api/Database.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ import {
3131
EmulatorMockTokenOptions,
3232
getDefaultEmulatorHostnameAndPort,
3333
isCloudWorkstation,
34-
pingServer,
35-
updateEmulatorBanner
34+
pingServer
3635
} from '@firebase/util';
3736

3837
import { AppCheckTokenProvider } from '../core/AppCheckTokenProvider';
@@ -394,7 +393,6 @@ export function connectDatabaseEmulator(
394393
// Workaround to get cookies in Firebase Studio
395394
if (isCloudWorkstation(host)) {
396395
void pingServer(host);
397-
updateEmulatorBanner('Database', true);
398396
}
399397

400398
// Modify the repo to apply emulator settings

packages/functions/src/service.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,7 @@ import { Provider } from '@firebase/component';
3030
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
3131
import { MessagingInternalComponentName } from '@firebase/messaging-interop-types';
3232
import { AppCheckInternalComponentName } from '@firebase/app-check-interop-types';
33-
import {
34-
isCloudWorkstation,
35-
pingServer,
36-
updateEmulatorBanner
37-
} from '@firebase/util';
33+
import { isCloudWorkstation, pingServer } from '@firebase/util';
3834

3935
export const DEFAULT_REGION = 'us-central1';
4036

@@ -186,7 +182,6 @@ export function connectFunctionsEmulator(
186182
// Workaround to get cookies in Firebase Studio
187183
if (useSsl) {
188184
void pingServer(functionsInstance.emulatorOrigin);
189-
updateEmulatorBanner('Functions', true);
190185
}
191186
}
192187

packages/storage/src/service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ import {
4646
createMockUserToken,
4747
EmulatorMockTokenOptions,
4848
isCloudWorkstation,
49-
pingServer,
50-
updateEmulatorBanner
49+
pingServer
5150
} from '@firebase/util';
5251
import { Connection, ConnectionType } from './implementation/connection';
5352

0 commit comments

Comments
 (0)