Cleanup: Use Object.assign() to create shallow copies (#2647)

Author: schmidt-sebastian

packages/firestore/src/util/api.ts

@@ -46,12 +46,8 @@ export function makeConstructorPrivate<T extends Function>(
   PublicConstructor.prototype = cls.prototype;
 
   // Copy any static methods/members
-  for (const staticProperty in cls) {
-    if (cls.hasOwnProperty(staticProperty)) {
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (PublicConstructor as any)[staticProperty] = (cls as any)[staticProperty];
-    }
-  }
+  Object.assign(PublicConstructor, cls);
+  
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   return PublicConstructor as any;
 }

packages/firestore/src/util/obj.ts

@@ -105,11 +105,5 @@ export function shallowCopy<V>(obj: Dict<V>): Dict<V> {
     obj && typeof obj === 'object',
     'shallowCopy() expects object parameter.'
   );
-  const result: Dict<V> = {};
-  for (const key in obj) {
-    if (Object.prototype.hasOwnProperty.call(obj, key)) {
-      result[key] = obj[key];
-    }
-  }
-  return result;
+  return { ...obj };
 }