address comments

Author: Feiyang1

packages-exp/firebase-exp/gulpfile.js

@@ -21,12 +21,10 @@ var sourcemaps = require('gulp-sourcemaps');
 
 const OUTPUT_FILE = 'firebase.js';
 const pkgJson = require('./package.json');
-const files = [
-  ...pkgJson.components.map(component => {
-    const componentName = component.replace('/', '-');
-    return `firebase-${componentName}.js`;
-  })
-];
+const files = pkgJson.components.map(component => {
+  const componentName = component.replace('/', '-');
+  return `firebase-${componentName}.js`;
+});
 
 gulp.task('firebase-js', function () {
   return gulp

packages/firestore/rollup.config.es2017.js

@@ -73,7 +73,7 @@ const browserBuildPlugins = [
       }
     },
     clean: true,
-    transformers: removeAssertAndPrefixInternalTransformer
+    transformers: [removeAssertAndPrefixInternalTransformer]
   }),
   json({ preferConst: true }),
   terser(manglePrivatePropertiesOptions)
@@ -146,7 +146,7 @@ const nodeBuildPlugins = [
       }
     },
     clean: true,
-    transformers: removeAssertTransformer
+    transformers: [removeAssertTransformer]
   }),
   json(),
   // Needed as we also use the *.proto files

packages/firestore/rollup.config.exp.js

@@ -44,7 +44,7 @@ const nodePlugins = [
     },
     clean: true,
     abortOnError: false,
-    transformers: [...removeAssertTransformer, importPathTransformer]
+    transformers: [removeAssertTransformer, importPathTransformer]
   }),
   json({ preferConst: true })
 ];
@@ -60,7 +60,7 @@ const browserPlugins = [
     clean: true,
     abortOnError: false,
     transformers: [
-      ...removeAssertAndPrefixInternalTransformer,
+      removeAssertAndPrefixInternalTransformer,
       importPathTransformer
     ]
   }),

packages/firestore/rollup.config.lite.js

@@ -44,7 +44,7 @@ const nodePlugins = [
     },
     clean: true,
     abortOnError: false,
-    transformers: [...removeAssertTransformer, importPathTransformer]
+    transformers: [removeAssertTransformer, importPathTransformer]
   }),
   json({ preferConst: true })
 ];
@@ -60,7 +60,7 @@ const browserPlugins = [
     clean: true,
     abortOnError: false,
     transformers: [
-      ...removeAssertAndPrefixInternalTransformer,
+      removeAssertAndPrefixInternalTransformer,
       importPathTransformer
     ]
   }),

packages/firestore/rollup.shared.js

@@ -63,29 +63,25 @@ const publicIdentifiers = extractPublicIdentifiers(externsPaths);
  * Transformers that remove calls to `debugAssert` and messages for 'fail` and
  * `hardAssert`.
  */
-export const removeAssertTransformer = [
-  service => ({
-    before: [removeAsserts(service.getProgram())],
-    after: []
-  })
-];
+export const removeAssertTransformer = service => ({
+  before: [removeAsserts(service.getProgram())],
+  after: []
+});
 
 /**
  * Transformers that remove calls to `debugAssert`, messages for 'fail` and
  * `hardAssert` and appends a __PRIVATE_ prefix to all internal symbols.
  */
-export const removeAssertAndPrefixInternalTransformer = [
-  service => ({
-    before: [
-      removeAsserts(service.getProgram()),
-      renameInternals(service.getProgram(), {
-        publicIdentifiers,
-        prefix: '__PRIVATE_'
-      })
-    ],
-    after: []
-  })
-];
+export const removeAssertAndPrefixInternalTransformer = service => ({
+  before: [
+    removeAsserts(service.getProgram()),
+    renameInternals(service.getProgram(), {
+      publicIdentifiers,
+      prefix: '__PRIVATE_'
+    })
+  ],
+  after: []
+});
 
 /**
  * Terser options that mangle all properties prefixed with __PRIVATE_.