Skip to content

Commit 4dcbbee

Browse files
committed
Enable COUNT integration tests, now that backend support has rolled out
1 parent de32c24 commit 4dcbbee

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

packages/firestore/test/integration/api_internal/aggregation.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ import {
3737
withTestCollection,
3838
withTestDb
3939
} from '../util/helpers';
40-
import { USE_EMULATOR } from '../util/settings';
4140

42-
(USE_EMULATOR ? apiDescribe : apiDescribe.skip)(
41+
apiDescribe(
4342
'Count quries',
4443
(persistence: boolean) => {
4544
it('can run count query getCountFromServer', () => {

packages/firestore/test/lite/integration.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ import { runTransaction } from '../../src/lite-api/transaction';
8383
import { writeBatch } from '../../src/lite-api/write_batch';
8484
import {
8585
DEFAULT_PROJECT_ID,
86-
DEFAULT_SETTINGS,
87-
USE_EMULATOR
86+
DEFAULT_SETTINGS
8887
} from '../integration/util/settings';
8988

9089
import {
@@ -2120,7 +2119,7 @@ describe('withConverter() support', () => {
21202119
});
21212120

21222121
// eslint-disable-next-line no-restricted-properties
2123-
(USE_EMULATOR ? describe : describe.skip)('Count quries', () => {
2122+
describe('Count quries', () => {
21242123
it('AggregateQuerySnapshot inherits the original query', () => {
21252124
return withTestCollection(async coll => {
21262125
const query_ = query(coll);

0 commit comments

Comments
 (0)