Finish cleaning up customHost params

Author: hsubox76

packages/storage/src/implementation/metadata.ts

@@ -156,7 +156,7 @@ export function fromResourceString(
 export function downloadUrlFromResourceString(
   metadata: Metadata,
   resourceString: string,
-  host?: string
+  host: string
 ): string | null {
   const obj = jsonObjectOrNull(resourceString);
   if (obj === null) {

packages/storage/src/implementation/url.ts

@@ -18,11 +18,10 @@
 /**
  * @fileoverview Functions to create and manipulate URLs for the server API.
  */
-import { DEFAULT_HOST } from './constants';
 import { UrlParams } from './requestinfo';
 
-export function makeUrl(urlPart: string, customHost?: string): string {
-  return `https://${customHost ?? DEFAULT_HOST}/v0${urlPart}`;
+export function makeUrl(urlPart: string, host: string): string {
+  return `https://${host}/v0${urlPart}`;
 }
 
 export function makeQueryString(params: UrlParams): string {

packages/storage/test/unit/requests.test.ts

@@ -200,7 +200,7 @@ describe('Firebase Storage > Requests', () => {
       const requestInfo = getMetadata(storageService, location, mappings);
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'GET',
           body: null,
           headers: {},
@@ -220,7 +220,7 @@ describe('Firebase Storage > Requests', () => {
     const requestInfo = list(storageService, locationRoot, '/');
     assertObjectIncludes(
       {
-        url: makeUrl(locationNormalNoObjUrl),
+        url: makeUrl(locationNormalNoObjUrl, storageService.host),
         method: 'GET',
         body: null,
         headers: {},
@@ -250,7 +250,7 @@ describe('Firebase Storage > Requests', () => {
       );
       assertObjectIncludes(
         {
-          url: makeUrl(locationNoObjectUrl),
+          url: makeUrl(locationNoObjectUrl, storageService.host),
           method: 'GET',
           body: null,
           headers: {},
@@ -317,7 +317,7 @@ describe('Firebase Storage > Requests', () => {
       const requestInfo = getDownloadUrl(storageService, location, mappings);
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'GET',
           body: null,
           headers: {},
@@ -352,7 +352,7 @@ describe('Firebase Storage > Requests', () => {
       );
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'PATCH',
           body: metadataString,
           headers: { 'Content-Type': metadataContentType },
@@ -383,7 +383,7 @@ describe('Firebase Storage > Requests', () => {
       const requestInfo = deleteObject(storageService, location);
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'DELETE',
           body: null,
           headers: {},
@@ -448,7 +448,7 @@ describe('Firebase Storage > Requests', () => {
 
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'POST',
           urlParams: { name: location.path },
           headers: {
@@ -493,7 +493,7 @@ describe('Firebase Storage > Requests', () => {
       );
       assertObjectIncludes(
         {
-          url: makeUrl(url),
+          url: makeUrl(url, storageService.host),
           method: 'POST',
           urlParams: { name: location.path },
           headers: {