Additional cleanup of sum/avg

Author: MarkDuckworth

packages/firestore/src/core/aggregate.ts

@@ -24,7 +24,7 @@ import { FieldPath } from '../model/path';
 export type AggregateType = 'count' | 'avg' | 'sum';
 
 /**
- * TODO
+ * Represents an Aggregate to be performed over a query result set.
  */
 export interface Aggregate {
   readonly fieldPath?: FieldPath;
@@ -33,7 +33,7 @@ export interface Aggregate {
 }
 
 /**
- * TODO
+ * Concrete implementation of the Aggregate type.
  */
 export class AggregateImpl implements Aggregate {
   constructor(
@@ -42,17 +42,3 @@ export class AggregateImpl implements Aggregate {
     readonly fieldPath?: FieldPath
   ) {}
 }
-
-/**
- * TODO
- * @param alias
- * @param aggregateType
- * @param fieldPath
- */
-export function newAggregate(
-  alias: string,
-  aggregateType: AggregateType,
-  fieldPath?: FieldPath
-): Aggregate {
-  return new AggregateImpl(alias, aggregateType, fieldPath);
-}

packages/firestore/src/core/firestore_client.ts

@@ -448,7 +448,7 @@ export function firestoreClientRunAggregateQuery(
   const deferred = new Deferred<ObjectValue>();
 
   client.asyncQueue.enqueueAndForget(async () => {
-    // TODO(aggregates) update this to use the event manager.
+    // TODO (sum/avg) should we update this to use the event manager?
     // Implement and call executeAggregateQueryViaSnapshotListener, similar
     // to the implementation in firestoreClientGetDocumentsViaSnapshotListener
     // above

packages/firestore/src/lite-api/aggregate_types.ts

@@ -28,12 +28,12 @@ export { AggregateType };
  * Represents an aggregation that can be performed by Firestore.
  */
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-export class AggregateField<R> {
+export class AggregateField<T> {
   /** A type string to uniquely identify instances of this class. */
   readonly type = 'AggregateField';
 
   /**
-   * Create a new AggregateField<R>
+   * Create a new AggregateField<T>
    * @param _aggregateType Specifies the type of aggregation operation to perform.
    * @param _internalFieldPath Optionally specifies the field that is aggregated.
    * @internal