PR feedback

Author: sam-gc

packages-exp/auth-exp/src/core/auth/auth_event_manager.ts

@@ -16,10 +16,7 @@
  */
 
 import {
-  AuthEvent,
-  AuthEventConsumer,
-  AuthEventType,
-  EventManager
+    AuthEvent, AuthEventConsumer, AuthEventType, EventManager
 } from '../../model/popup_redirect';
 import { AUTH_ERROR_FACTORY, AuthErrorCode } from '../errors';
 
@@ -81,7 +78,6 @@ export class AuthEventManager implements EventManager {
 
   private sendToConsumer(event: AuthEvent, consumer: AuthEventConsumer): void {
     if (event.error) {
-      console.error('ERROR');
       const code =
         (event.error.code?.split('auth/')[1] as AuthErrorCode) ||
         AuthErrorCode.INTERNAL_ERROR;

packages-exp/auth-exp/src/core/strategies/popup.ts

@@ -18,12 +18,10 @@
 import * as externs from '@firebase/auth-types-exp';
 
 import { Auth } from '../../model/auth';
-import {
-  AuthEventType,
-  PopupRedirectResolver
-} from '../../model/popup_redirect';
+import { AuthEventType, PopupRedirectResolver } from '../../model/popup_redirect';
 import { User } from '../../model/user';
 import { AUTH_ERROR_FACTORY, AuthErrorCode } from '../errors';
+import { debugAssert } from '../util/assert';
 import { Delay } from '../util/delay';
 import { _generateEventId } from '../util/event_id';
 import { _getInstance } from '../util/instantiator';
@@ -114,6 +112,7 @@ class PopupOperation extends AbstractPopupRedirectOperation {
   }
 
   async onExecution(): Promise<void> {
+    debugAssert(this.filter.length === 1, 'Popup operations only handle one event');
     const eventId = _generateEventId();
     this.authWindow = await this.resolver._openPopup(
       this.auth,

packages-exp/auth-exp/src/platform_browser/popup_redirect.ts

@@ -28,11 +28,7 @@ import { _getCurrentUrl } from '../core/util/location';
 import { _open, AuthPopup } from '../core/util/popup';
 import { ApiKey, AppName, Auth } from '../model/auth';
 import {
-  AuthEventType,
-  EventManager,
-  GapiAuthEvent,
-  GapiOutcome,
-  PopupRedirectResolver
+    AuthEventType, EventManager, GapiAuthEvent, GapiOutcome, PopupRedirectResolver
 } from '../model/popup_redirect';
 import { _setWindowLocation } from './auth_window';
 import { _openIframe } from './iframe/iframe';
@@ -90,6 +86,7 @@ class BrowserPopupRedirectResolver implements PopupRedirectResolver {
     iframe.register<GapiAuthEvent>(
       'authEvent',
       ({ authEvent }: GapiAuthEvent) => {
+        // TODO: Consider splitting redirect and popup events earlier on
         const handled = eventManager.onEvent(authEvent);
         return { status: handled ? GapiOutcome.ACK : GapiOutcome.ERROR };
       },