Fixed storage-types to use proper StorageError

Author: maneesht

common/api-review/storage.api.md

@@ -229,7 +229,7 @@ export class StorageError extends FirebaseError {
     }
 
 // @public
-export const enum StorageErrorCode {
+export enum StorageErrorCode {
     // (undocumented)
     APP_DELETED = "app-deleted",
     // (undocumented)

packages/storage-types/index.d.ts

@@ -16,10 +16,10 @@
  */
 
 import { FirebaseApp } from '@firebase/app-types';
+import { StorageError as FirebaseStorageError } from '@firebase/storage';
 import {
   CompleteFn,
   EmulatorMockTokenOptions,
-  FirebaseError,
   NextFn,
   Unsubscribe
 } from '@firebase/util';
@@ -91,10 +91,6 @@ export interface UploadMetadata extends SettableMetadata {
   md5Hash?: string | null;
 }
 
-interface FirebaseStorageError extends FirebaseError {
-  serverResponse: string | null;
-}
-
 export interface StorageObserver<T> {
   next?: NextFn<T> | null;
   error?: (error: FirebaseStorageError) => void | null;

packages/storage/src/implementation/error.ts

@@ -85,7 +85,7 @@ export const errors = {};
  * @public
  * Error codes that can be attached to `StorageError`s.
  */
-export const enum StorageErrorCode {
+export enum StorageErrorCode {
   // Shared between all platforms
   UNKNOWN = 'unknown',
   OBJECT_NOT_FOUND = 'object-not-found',