Skip to content

Commit 5760b02

Browse files
Simplify
1 parent 634145a commit 5760b02

File tree

3 files changed

+5
-34
lines changed

3 files changed

+5
-34
lines changed

packages/firestore/lite/index.node.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,15 @@
1616
*/
1717

1818
import { registerVersion, _registerComponent } from '@firebase/app-exp';
19-
import {
20-
Firestore,
21-
initializeFirestore,
22-
getFirestore
23-
} from './src/api/database';
19+
import { Firestore } from './src/api/database';
2420
import { version } from '../package.json';
2521
import { Component, ComponentType } from '@firebase/component';
2622

27-
import { makeConstructorPrivate } from '../src/util/api';
28-
29-
export const PublicFirestore = makeConstructorPrivate(
23+
export {
3024
Firestore,
31-
'Use getFirestore() instead.'
32-
);
33-
34-
const firestoreNamespace = {
35-
Firestore: PublicFirestore,
3625
initializeFirestore,
3726
getFirestore
38-
};
27+
} from './src/api/database';
3928

4029
export function registerFirestore(): void {
4130
_registerComponent(
@@ -49,7 +38,7 @@ export function registerFirestore(): void {
4938
);
5039
},
5140
ComponentType.PUBLIC
52-
).setServiceProps({ ...firestoreNamespace })
41+
)
5342
);
5443
registerVersion('firestore-lite', version, 'node');
5544
}

packages/firestore/lite/src/api/database.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,5 @@ export function initializeFirestore(
9696
}
9797

9898
export function getFirestore(app: FirebaseApp): Firestore {
99-
const firestore = _getProvider(
100-
app,
101-
'firestore/lite'
102-
).getImmediate() as Firestore;
103-
firestore._ensureClientConfigured();
104-
return firestore;
99+
return _getProvider(app, 'firestore/lite').getImmediate() as Firestore;
105100
}

packages/firestore/lite/test/integration.test.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,4 @@ describe('Firestore', () => {
3838
const fs2 = getFirestore(app);
3939
expect(fs1 === fs2).to.be.true;
4040
});
41-
42-
it('cannot call initializeFirestore() after getFirestore()', () => {
43-
const app = initializeApp(
44-
{ apiKey: 'fake-api-key', projectId: 'test-project' },
45-
'test-app-getFirestore-initializeFirestore'
46-
);
47-
getFirestore(app);
48-
expect(() => initializeFirestore(app, {})).to.throw(
49-
'Firestore has already been started and its settings can no longer ' +
50-
'be changed. initializeFirestore() cannot be called after calling ' +
51-
'getFirestore().'
52-
);
53-
});
5441
});

0 commit comments

Comments
 (0)