Skip to content

Commit 585fbae

Browse files
committed
Address PR comments
1 parent cb0a16a commit 585fbae

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

packages/storage/.eslintrc.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ module.exports = {
3737
'import/no-extraneous-dependencies': [
3838
'error',
3939
{
40-
'packageDir': [path.resolve(__dirname, '../../'), __dirname],
41-
devDependencies: true
40+
'packageDir': [path.resolve(__dirname, '../../'), __dirname]
4241
}
4342
]
4443
}

packages/storage/src/service.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { Provider } from '@firebase/component';
2727
import { FirebaseAuthInternalName } from '@firebase/auth-interop-types';
2828
import { FirebaseOptions } from '@firebase/app-types-exp';
2929
import * as constants from '../src/implementation/constants';
30-
import { requestMaker } from './implementation/requestmaker';
3130
import * as errorsExports from './implementation/error';
3231

3332
/**
@@ -42,8 +41,6 @@ export class StorageService {
4241
private readonly internals_: ServiceInternals;
4342
private readonly authProvider_: Provider<FirebaseAuthInternalName>;
4443
private readonly appId_: string | null = null;
45-
46-
private readonly requestMaker_: requestMaker;
4744
private readonly pool_: XhrIoPool;
4845
private readonly requests_: Set<Request<unknown>>;
4946
private deleted_: boolean = false;
@@ -58,7 +55,6 @@ export class StorageService {
5855
) {
5956
this.app_ = app;
6057
this.authProvider_ = authProvider;
61-
this.requestMaker_ = makeRequest;
6258
this.maxOperationRetryTime_ = constants.DEFAULT_MAX_OPERATION_RETRY_TIME;
6359
this.maxUploadRetryTime_ = constants.DEFAULT_MAX_UPLOAD_RETRY_TIME;
6460
this.requests_ = new Set();
@@ -115,7 +111,7 @@ export class StorageService {
115111
authToken: string | null
116112
): Request<T> {
117113
if (!this.deleted_) {
118-
const request = this.requestMaker_(
114+
const request = makeRequest(
119115
requestInfo,
120116
this.appId_,
121117
authToken,

0 commit comments

Comments
 (0)