fixed lint errors

Author: XuechunHou

repo-scripts/size-analysis/analysis-helper.ts

@@ -733,7 +733,9 @@ export async function generateReportForModule(
       `Firebase Module locates at ${moduleLocation}: ${ErrorCode.PKG_JSON_DOES_NOT_EXIST}`
     );
   }
-  const packageJson = require(packageJsonPath);
+  const packageJson = JSON.parse(
+    fs.readFileSync(packageJsonPath, { encoding: 'utf-8' })
+  );
   // to exclude <modules>-types modules
   const TYPINGS: string = 'typings';
   if (packageJson[TYPINGS]) {
@@ -822,7 +824,9 @@ async function traverseDirs(
     if (
       fs.lstatSync(p).isDirectory() &&
       fs.existsSync(`${p}/package.json`) &&
-      require(`${p}/package.json`)[generateSizeAnalysisReportPkgJsonField]
+      JSON.parse(fs.readFileSync(`${p}/package.json`, { encoding: 'utf-8' }))[
+        generateSizeAnalysisReportPkgJsonField
+      ]
     ) {
       const subModuleReports: Report[] = await traverseDirs(
         p,

repo-scripts/size-analysis/analysis.ts

@@ -27,6 +27,7 @@ import {
 import { mapWorkspaceToPackages } from '../../scripts/release/utils/workspace';
 import { projectRoot } from '../../scripts/utils';
 import * as yargs from 'yargs';
+import * as fs from 'fs';
 
 /**
  * Support Command Line Options
@@ -93,7 +94,9 @@ async function main(): Promise<void> {
       `${projectRoot}/packages-exp/*`
     ]);
     allModulesLocation = allModulesLocation.filter(path => {
-      const json = require(`${path}/package.json`);
+      const json = JSON.parse(
+        fs.readFileSync(`${path}/package.json`, { encoding: 'utf-8' })
+      );
       return (
         json.name.startsWith('@firebase') &&
         !json.name.includes('-compat') &&
@@ -102,7 +105,9 @@ async function main(): Promise<void> {
     });
     if (argv.inputModule) {
       allModulesLocation = allModulesLocation.filter(path => {
-        const json = require(`${path}/package.json`);
+        const json = JSON.parse(
+          fs.readFileSync(`${path}/package.json`, { encoding: 'utf-8' })
+        );
         return argv.inputModule.includes(json.name);
       });
     }
@@ -128,4 +133,6 @@ async function main(): Promise<void> {
   }
 }
 
-main();
+main().catch(error => {
+  console.log(error);
+});

repo-scripts/size-analysis/package.json

@@ -6,7 +6,9 @@
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.cjs.js",
   "esm2017": "dist/index.esm2017.js",
-  "files": ["dist"],
+  "files": [
+    "dist"
+  ],
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
@@ -16,18 +18,22 @@
     "type-check": "tsc -p . --noEmit"
   },
   "dependencies": {
-    "typescript": "3.9.7",
+    "@firebase/app": "0.6.10",
+    "@firebase/util": "0.3.1",
     "rollup": "2.23.0",
+    "rollup-plugin-commonjs": "10.1.0",
     "rollup-plugin-json": "4.0.0",
+    "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.27.1",
-    "rollup-plugin-commonjs": "10.1.0",
-    "rollup-plugin-node-resolve": "5.2.0"
+    "tmp": "^0.2.1",
+    "typescript": "3.9.7",
+    "terser": "4.8.0",
+    "yargs": "15.4.1"
   },
   "license": "Apache-2.0",
   "devDependencies": {
-    "@firebase/logger": "0.2.6",
-    "@firebase/util": "0.3.1"
+    "@firebase/logger": "0.2.6"
   },
   "repository": {
     "directory": "repo-scripts/size-analysis",
@@ -43,4 +49,4 @@
     ],
     "reportDir": "./coverage/node"
   }
-}
+}

repo-scripts/size-analysis/test/test-inputs/assortedImports.ts

@@ -19,9 +19,9 @@ import '@firebase/logger';
 import * as fs from 'fs';
 import {
   basicFuncExportEnumDependenciesBar,
-  basicFuncExternalDependenciesBar
+  basicFuncExternalDependenciesBar,
+  BasicClassExportBar as BasicClassExportBarRenamed
 } from './bar';
-import { BasicClassExportBar as BasicClassExportBarRenamed } from './bar';
 import defaultExport from '@firebase/app';
 console.log(
   fs,

repo-scripts/size-analysis/test/test-inputs/far.ts

@@ -65,7 +65,7 @@ export function basicUniqueFuncFar(
 export function basicUniqueFuncFar(x: number): { suit: string; card: number };
 export function basicUniqueFuncFar(
   x: number | Array<{ suit: string; card: number }>
-) {
+): number | { suit: string; card: number } {
   if (typeof x === 'object') {
     const pickedCard = Math.floor(Math.random() * x.length);
     return pickedCard;

repo-scripts/size-analysis/test/test-inputs/index.ts

@@ -95,11 +95,9 @@ export function basicUniqueFunc(
   }
 }
 
-const appsNotExported: Map<string, number> = new Map();
 const apps: Map<string, number> = new Map();
 export { apps };
 
-class FooNotExported {}
 class Foo {}
 export { Foo as Foo1 };
 

yarn.lock

@@ -14705,7 +14705,7 @@ [email protected], tmp@^0.0.33:
   dependencies:
     os-tmpdir "~1.0.2"
 
-[email protected]:
+[email protected], tmp@^0.2.1:
   version "0.2.1"
   resolved "https://registry.npmjs.org/tmp/-/tmp-0.2.1.tgz#8457fc3037dcf4719c251367a1af6500ee1ccf14"
   integrity sha512-76SUhtfqR2Ijn+xllcI5P1oyannHNHByD80W1q447gU3mp9G9PSpGdWmjUOHRDPiHYacIk66W7ubDTuPF3BEtQ==