Apply ErrorList type

Author: mmermerkaya

packages/app/src/errors.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { ErrorFactory } from '@firebase/util';
+import { ErrorFactory, ErrorList } from '@firebase/util';
 
 export const enum AppError {
   NO_APP = 'no-app',
@@ -26,7 +26,7 @@ export const enum AppError {
   INVALID_APP_ARGUMENT = 'invalid-app-argument'
 }
 
-const errors: { readonly [code in AppError]: string } = {
+const errors: ErrorList<AppError> = {
   [AppError.NO_APP]:
     "No Firebase App '{$name}' has been created - " +
     'call Firebase App.initializeApp()',
@@ -40,7 +40,7 @@ const errors: { readonly [code in AppError]: string } = {
     'Firebase App instance.'
 };
 
-let appErrors = new ErrorFactory<AppError>('app', 'Firebase', errors);
+const appErrors = new ErrorFactory('app', 'Firebase', errors);
 
 export function error(code: AppError, args?: { [name: string]: any }) {
   throw appErrors.create(code, args);

packages/messaging/src/models/errors.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { ErrorFactory } from '@firebase/util';
+import { ErrorFactory, ErrorList } from '@firebase/util';
 
 export const enum ErrorCode {
   AVAILABLE_IN_WINDOW = 'only-available-in-window',
@@ -59,7 +59,7 @@ export const enum ErrorCode {
   PUBLIC_KEY_DECRYPTION_FAILED = 'public-vapid-key-decryption-failed'
 }
 
-export const ERROR_MAP: { [code in ErrorCode]: string } = {
+export const ERROR_MAP: ErrorList<ErrorCode> = {
   [ErrorCode.AVAILABLE_IN_WINDOW]:
     'This method is available in a Window context.',
   [ErrorCode.AVAILABLE_IN_SW]:
@@ -156,7 +156,7 @@ export const ERROR_MAP: { [code in ErrorCode]: string } = {
     'The public VAPID key did not equal ' + '65 bytes when decrypted.'
 };
 
-export const errorFactory: ErrorFactory<string> = new ErrorFactory(
+export const errorFactory = new ErrorFactory(
   'messaging',
   'Messaging',
   ERROR_MAP

packages/util/src/errors.ts

@@ -54,8 +54,9 @@
  *     }
  *   }
  */
-export type ErrorList<T extends string = string> = {
-  readonly [K in T]: string
+
+export type ErrorList<ErrorCode extends string> = {
+  readonly [K in ErrorCode]: string
 };
 
 const ERROR_NAME = 'FirebaseError';