Skip to content

Commit 5d1e3a4

Browse files
committed
Clean up and re-enable some OR query tests.
1 parent 8e9aac2 commit 5d1e3a4

File tree

1 file changed

+2
-29
lines changed

1 file changed

+2
-29
lines changed

packages/firestore/test/integration/api/query.test.ts

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,10 +1515,7 @@ apiDescribe('Queries', (persistence: boolean) => {
15151515
});
15161516
});
15171517

1518-
// TODO(orquery) enable this test when the backend supports
1519-
// one in per disjunction
1520-
// eslint-disable-next-line no-restricted-properties
1521-
it.skip('supports multiple in ops', () => {
1518+
it('supports multiple in ops', () => {
15221519
const testDocs = {
15231520
doc1: { a: 1, b: 0 },
15241521
doc2: { b: 1 },
@@ -1546,10 +1543,7 @@ apiDescribe('Queries', (persistence: boolean) => {
15461543
});
15471544
});
15481545

1549-
// TODO(orquery) enable this test when the backend supports
1550-
// one in or array-contains-any per disjunction
1551-
// eslint-disable-next-line no-restricted-properties
1552-
it.skip('supports using in with array contains any', () => {
1546+
it('supports using in with array contains any', () => {
15531547
const testDocs = {
15541548
doc1: { a: 1, b: [0] },
15551549
doc2: { b: [1] },
@@ -1734,27 +1728,6 @@ apiDescribe('Queries', (persistence: boolean) => {
17341728
});
17351729
});
17361730

1737-
it('can use or queries with not-in', () => {
1738-
const testDocs = {
1739-
doc1: { a: 1, b: 0 },
1740-
doc2: { b: 1 },
1741-
doc3: { a: 3, b: 2 },
1742-
doc4: { a: 1, b: 3 },
1743-
doc5: { a: 1 },
1744-
doc6: { a: 2 }
1745-
};
1746-
1747-
return withTestCollection(persistence, testDocs, async coll => {
1748-
// a==2 || b not-in [2,3]
1749-
// Has implicit orderBy b.
1750-
await checkOnlineAndOfflineResultsMatch(
1751-
query(coll, or(where('a', '==', 2), where('b', 'not-in', [2, 3]))),
1752-
'doc1',
1753-
'doc2'
1754-
);
1755-
});
1756-
});
1757-
17581731
// eslint-disable-next-line no-restricted-properties
17591732
it('supports order by equality', () => {
17601733
const testDocs = {

0 commit comments

Comments
 (0)