Remove tests

Author: schmidt-sebastian

packages/firestore/.idea/runConfigurations/Unit_Tests__w__Mock_Persistence_.xml

@@ -527,7 +527,7 @@ function queryMatchesBounds(query: Query, doc: Document): boolean {
 }
 
 /** Returns the collection group that this query targets. */
-export function queryGetCollectionGroup(query: Query): string {
+export function queryCollectionGroup(query: Query): string {
   return (
     query.collectionGroup ||
     (query.path.length % 2 === 1

packages/firestore/src/core/query.ts

@@ -92,7 +92,7 @@ import {
   newQueryForPath,
   Query,
   queryEquals,
-  queryGetCollectionGroup,
+  queryCollectionGroup,
   queryToTarget,
   stringifyQuery
 } from './query';
@@ -1443,7 +1443,7 @@ export async function syncEngineApplyTargetState(
       case 'not-current': {
         const changes = await localStoreGetNewDocumentChanges(
           syncEngineImpl.localStore,
-          queryGetCollectionGroup(query[0])
+          queryCollectionGroup(query[0])
         );
         const synthesizedRemoteEvent =
           RemoteEvent.createSynthesizedRemoteEventForCurrentChange(

packages/firestore/src/core/sync_engine_impl.ts

@@ -20,7 +20,7 @@ import { BundleConverter, BundledDocuments, NamedQuery } from '../core/bundle';
 import {
   newQueryForPath,
   Query,
-  queryGetCollectionGroup,
+  queryCollectionGroup,
   queryToTarget
 } from '../core/query';
 import { SnapshotVersion } from '../core/snapshot_version';
@@ -1010,7 +1010,7 @@ export function localStoreExecuteQuery(
         )
         .next(documents => {
           localStoreImpl.collectionGroupReatTime.set(
-            queryGetCollectionGroup(query),
+            queryCollectionGroup(query),
             getMaxReadTime(documents)
           );
           return { documents, remoteKeys };

packages/firestore/src/local/local_store_impl.ts

@@ -34,7 +34,9 @@ import {
   queryToTarget,
   QueryImpl,
   queryEquals,
-  matchesAllDocuments
+  matchesAllDocuments,
+  queryCollectionGroup,
+  newQueryForCollectionGroup
 } from '../../../src/core/query';
 import {
   Bound,
@@ -89,6 +91,14 @@ describe('Bound', () => {
 describe('Query', () => {
   addEqualityMatcher({ equalsFn: queryEquals, forType: QueryImpl });
 
+  it('can get collection group', () => {
+    expect(queryCollectionGroup(query('foo'))).to.equal('foo');
+    expect(queryCollectionGroup(query('foo/bar'))).to.equal('foo');
+    expect(queryCollectionGroup(newQueryForCollectionGroup('foo'))).to.equal(
+      'foo'
+    );
+  });
+
   it('matches based on document key', () => {
     const queryKey = new ResourcePath(['rooms', 'eros', 'messages', '1']);
     const doc1 = doc('rooms/eros/messages/1', 0, { text: 'msg1' });

packages/firestore/test/unit/core/query.test.ts

@@ -61,7 +61,6 @@ import {
   DbRemoteDocumentGlobalKey,
   DbRemoteDocumentGlobalStore,
   DbRemoteDocumentKey,
-  DbRemoteDocumentReadTimeIndex,
   DbRemoteDocumentStore,
   DbTargetDocumentKey,
   DbTargetDocumentStore,
@@ -1029,41 +1028,6 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
     });
   });
 
-  it('can get recent document changes', async function (this: Context) {
-    const oldDocPaths = ['coll1/old', 'coll2/old'];
-    const newDocPaths = ['coll1/new', 'coll2/new'];
-
-    await withDb(13, db => {
-      return db.runTransaction(
-        this.test!.fullTitle(),
-        'readwrite',
-        V13_STORES,
-        txn => {
-          return addDocs(txn, oldDocPaths, /* version= */ 1).next(() =>
-            addDocs(txn, newDocPaths, /* version= */ 2).next(() => {
-              const remoteDocumentStore = txn.store<
-                DbRemoteDocumentKey,
-                DbRemoteDocument
-              >(DbRemoteDocumentStore);
-
-              const lastReadTime = toDbTimestampKey(version(1));
-              const range = IDBKeyRange.lowerBound(lastReadTime, true);
-              return remoteDocumentStore
-                .loadAll(DbRemoteDocumentReadTimeIndex, range)
-                .next(docsRead => {
-                  const keys = docsRead.map(dbDoc => dbDoc.document!.name);
-                  expect(keys).to.have.members([
-                    'projects/test-project/databases/(default)/documents/coll1/new',
-                    'projects/test-project/databases/(default)/documents/coll2/new'
-                  ]);
-                });
-            })
-          );
-        }
-      );
-    });
-  });
-
   it('can upgrade from version 11 to 12', async () => {
     await withDb(11, async () => {});
     await withDb(12, async (db, version, objectStores) => {

packages/firestore/test/unit/local/indexeddb_persistence.test.ts

@@ -51,7 +51,6 @@ import {
   localStoreReleaseTarget,
   localStoreSaveBundle,
   localStoreSaveNamedQuery,
-  localStoreSynchronizeLastDocumentChangeReadTime,
   newLocalStore
 } from '../../../src/local/local_store_impl';
 import { LocalViewChanges } from '../../../src/local/local_view_changes';
@@ -579,7 +578,6 @@ describe('LocalStore w/ IndexedDB Persistence', () => {
       User.UNAUTHENTICATED,
       JSON_SERIALIZER
     );
-    await localStoreSynchronizeLastDocumentChangeReadTime(localStore);
     return { queryEngine, persistence, localStore };
   }
 

packages/firestore/test/unit/local/local_store.test.ts

@@ -18,9 +18,7 @@
 import { expect } from 'chai';
 
 import { User } from '../../../src/auth/user';
-import { SnapshotVersion } from '../../../src/core/snapshot_version';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
-import { remoteDocumentCacheGetLastReadTime } from '../../../src/local/indexeddb_remote_document_cache';
 import { documentKeySet, DocumentMap } from '../../../src/model/collections';
 import { MutableDocument, Document } from '../../../src/model/document';
 import {
@@ -36,7 +34,6 @@ import {
   field,
   key,
   path,
-  removedDoc,
   version,
   wrap
 } from '../../util/helpers';
@@ -109,81 +106,6 @@ describe('IndexedDbRemoteDocumentCache', () => {
     await persistenceHelpers.clearTestPersistence();
   });
 
-  function getLastReadTime(): Promise<SnapshotVersion> {
-    return persistence.runTransaction('getLastReadTime', 'readonly', txn => {
-      return remoteDocumentCacheGetLastReadTime(txn);
-    });
-  }
-
-  it('skips previous changes', async () => {
-    // Add a document to simulate a previous run.
-    await cache.addEntries([doc('a/1', 1, DOC_DATA).setReadTime(version(1))]);
-    await persistence.shutdown();
-
-    // Start a new run of the persistence layer
-    persistence = await persistenceHelpers.testIndexedDbPersistence({
-      synchronizeTabs: true,
-      dontPurgeData: true
-    });
-    cache = new TestRemoteDocumentCache(persistence);
-    const readTime = await getLastReadTime();
-    const { changedDocs } = await cache.getNewDocumentChanges(readTime);
-    assertMatches([], changedDocs);
-  });
-
-  it('can get changes', async () => {
-    await cache.addEntries([
-      doc('a/1', 1, DOC_DATA),
-      doc('b/1', 2, DOC_DATA),
-      doc('b/2', 2, DOC_DATA),
-      doc('a/1', 3, DOC_DATA)
-    ]);
-
-    let { changedDocs, readTime } = await cache.getNewDocumentChanges(
-      SnapshotVersion.min()
-    );
-    assertMatches(
-      [
-        doc('a/1', 3, DOC_DATA),
-        doc('b/1', 2, DOC_DATA),
-        doc('b/2', 2, DOC_DATA)
-      ],
-      changedDocs
-    );
-
-    await cache.addEntry(doc('c/1', 4, DOC_DATA));
-    changedDocs = (await cache.getNewDocumentChanges(readTime)).changedDocs;
-    assertMatches([doc('c/1', 4, DOC_DATA)], changedDocs);
-  });
-
-  it('can get empty changes', async () => {
-    const { changedDocs } = await cache.getNewDocumentChanges(
-      SnapshotVersion.min()
-    );
-    assertMatches([], changedDocs);
-  });
-
-  it('can get missing documents in changes', async () => {
-    await cache.addEntries([
-      doc('a/1', 1, DOC_DATA),
-      doc('a/2', 2, DOC_DATA),
-      doc('a/3', 3, DOC_DATA)
-    ]);
-    await cache.removeEntry(key('a/2'), version(4));
-
-    const { changedDocs } = await cache.getNewDocumentChanges(
-      SnapshotVersion.min()
-    );
-    assertMatches(
-      [
-        doc('a/1', 1, DOC_DATA),
-        removedDoc('a/2').setReadTime(version(4)),
-        doc('a/3', 3, DOC_DATA)
-      ],
-      changedDocs
-    );
-  });
-
   it('can get next documents from collection group', async () => {
     await cache.addEntries([
       doc('a/1', 1, DOC_DATA),