Skip to content

Commit 5ee6096

Browse files
committed
Addressed comments
1 parent 5fd68d8 commit 5ee6096

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

.changeset/tame-rice-peel.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
---
22
"@firebase/app-check": patch
3-
"@firebase/app": patch
43
"@firebase/database": patch
54
"@firebase/util": patch
65
---

common/api-review/util.api.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,8 +422,6 @@ export interface Subscribe<T> {
422422
// @public (undocumented)
423423
export type Unsubscribe = () => void;
424424

425-
// Warning: (ae-missing-release-tag) "uuidv4" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
426-
//
427425
// @public
428426
export const uuidv4: () => string;
429427

packages/database/src/api/Database.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ import { Provider } from '@firebase/component';
2727
import {
2828
getModularInstance,
2929
createMockUserToken,
30-
EmulatorMockTokenOptions
30+
EmulatorMockTokenOptions,
31+
uuidv4
3132
} from '@firebase/util';
3233

3334
import { AppCheckTokenProvider } from '../core/AppCheckTokenProvider';

packages/database/test/helpers/util.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { uuidv4 } from '@firebase/util';
18+
import * as Util from '@firebase/util';
1919

2020
import { Database, ref } from '../../src';
2121
import { ConnectionTarget } from '../../src/api/test_access';
@@ -82,6 +82,6 @@ export function waitFor(waitTimeInMS: number) {
8282

8383
// Creates a unique reference using uuid
8484
export function getUniqueRef(db: Database) {
85-
const path = uuidv4();
85+
const path = Util.uuidv4();
8686
return { ref: ref(db, path), path };
8787
}

packages/util/index.node.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export * from './src/sha1';
3636
export * from './src/subscribe';
3737
export * from './src/validation';
3838
export * from './src/utf8';
39+
export * from './src/uuid';
3940
export * from './src/exponential_backoff';
4041
export * from './src/formatters';
4142
export * from './src/compat';

packages/util/src/uuid.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
/**
1919
* Copied from https://stackoverflow.com/a/2117523
2020
* Generates a new uuid.
21+
* @public
2122
*/
2223
export const uuidv4 = function (): string {
2324
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, c => {

0 commit comments

Comments
 (0)