Prepare auth-next for merging to master (#3740)

* suppress eslint error

* fix type error

* make auth-compat depend on app-compat

* add release build for auth-exp

* revert auth-compat to depend on app

* test

* don't abort on error for release builds

* apply release build to web worker build

* Revert "test"

This reverts commit 8be511c.

* fix lint error

Author: Feiyang1

packages-exp/auth-compat-exp/package.json

@@ -5,7 +5,7 @@
   "description": "FirebaseAuth compatibility package that uses API style compatible with Firebase@7 and prior versions",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.node.cjs.js",
-  "browser": "dist/index.cjs.js",
+  "browser": "dist/index.esm.js",
   "module": "dist/index.esm.js",
   "esm2017": "dist/index.esm2017.js",
   "files": [
@@ -15,28 +15,30 @@
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "build": "rollup -c",
-    "build:deps": "lerna run --scope @firebase/'{app,auth-exp}' --include-dependencies build",
+    "build:deps": "lerna run --scope @firebase/auth-compat --include-dependencies build",
     "dev": "rollup -c -w",
-    "test": "yarn type-check && run-p lint test:browser test:node",
+    "test": "run-p lint test:all",
+    "test:all": "run-p test:browser test:node",
+    "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
     "test:browser": "karma start --single-run",
     "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha src/**/*.test.* --opts ../../config/mocha.node.opts",
-    "type-check": "tsc -p . --noEmit",
     "prepare": "yarn build"
   },
   "peerDependencies": {
-    "@firebase/app": "0.x"
+    "@firebase/app": "0.x",
+    "@firebase/app-types": "0.x"
   },
   "dependencies": {
     "@firebase/auth-types": "0.10.1",
     "@firebase/auth-exp": "0.0.800",
     "@firebase/auth-types-exp": "0.0.800",
-    "@firebase/component":  "0.1.18",
-    "@firebase/installations": "0.4.16",
+    "@firebase/component": "0.1.18",
     "@firebase/util": "0.3.0",
     "tslib": "^1.11.1"
   },
   "license": "Apache-2.0",
   "devDependencies": {
+    "@firebase/app": "0.6.10",
     "rollup": "2.23.0",
     "rollup-plugin-json": "4.0.0",
     "rollup-plugin-replace": "2.2.0",
@@ -57,4 +59,4 @@
     ],
     "reportDir": "./coverage/node"
   }
-}
+}

packages-exp/auth-compat-exp/rollup.config.js

@@ -22,11 +22,9 @@ import typescriptPlugin from 'rollup-plugin-typescript2';
 import typescript from 'typescript';
 import pkg from './package.json';
 
-const deps = [
-  '@firebase/app',
-  '@firebase/component',
-  '@firebase/installations'
-];
+const deps = Object.keys(
+  Object.assign({}, pkg.peerDependencies, pkg.dependencies)
+);
 
 /**
  * Common plugins for all builds
@@ -49,10 +47,7 @@ const es5Builds = [
    */
   {
     input: 'index.ts',
-    output: [
-      { file: pkg.browser, format: 'cjs', sourcemap: true },
-      { file: pkg.module, format: 'esm', sourcemap: true }
-    ],
+    output: [{ file: pkg.module, format: 'esm', sourcemap: true }],
     plugins: es5BuildPlugins,
     external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
   },

packages-exp/auth-compat-exp/src/auth.ts

@@ -15,8 +15,6 @@
  * limitations under the License.
  */
 
-import '@firebase/installations';
-
 import { FirebaseApp } from '@firebase/app-types';
 import * as impl from '@firebase/auth-exp/internal';
 import * as compat from '@firebase/auth-types';

packages-exp/auth-compat-exp/src/recaptcha_verifier.ts

@@ -33,6 +33,11 @@ export class RecaptchaVerifier
     impl.assertFn(app.options?.apiKey, impl.AuthErrorCode.INVALID_API_KEY, {
       appName: app.name
     });
-    super(container, parameters, (app.auth!() as unknown) as externs.Auth);
+    super(
+      container,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      parameters as any,
+      (app.auth!() as unknown) as externs.Auth
+    );
   }
 }

packages-exp/auth-compat-exp/src/user.ts

@@ -18,7 +18,6 @@
 import * as impl from '@firebase/auth-exp/internal';
 import * as compat from '@firebase/auth-types';
 import * as externs from '@firebase/auth-types-exp';
-import '@firebase/installations';
 import {
   convertConfirmationResult,
   convertCredential

packages-exp/auth-compat-exp/src/user_credential.ts

@@ -18,7 +18,6 @@
 import * as impl from '@firebase/auth-exp/internal';
 import * as compat from '@firebase/auth-types';
 import * as externs from '@firebase/auth-types-exp';
-import '@firebase/installations';
 import { User } from './user';
 
 function credentialFromResponse(

packages-exp/auth-exp/package.json

@@ -18,19 +18,18 @@
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "build": "rollup -c",
     "build:deps": "lerna run --scope @firebase/auth-exp --include-dependencies build",
-    "build:release": "rollup -c rollup.config.release.js && yarn api-report && yarn typings:public",
+    "build:release": "rollup -c rollup.config.release.js",
     "dev": "rollup -c -w",
-    "test": "yarn type-check && run-p lint test:browser test:node",
+    "test": "run-p lint test:all",
+    "test:all": "run-p test:browser test:node",
+    "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
     "test:browser": "karma start --single-run",
     "test:browser:unit": "karma start --single-run --unit",
     "test:browser:integration": "karma start --single-run --integration",
     "test:browser:debug": "karma start --auto-watch",
     "test:browser:unit:debug": "karma start --auto-watch --unit",
     "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/!(platform_browser|platform_react_native)/**/*.test.ts' --file index.node.ts --config ../../config/mocharc.node.js",
-    "type-check": "tsc -p . --noEmit",
-    "prepare": "yarn build",
-    "typings:public": "node ./use_typings.js --public",
-    "typings:internal": "node ./use_typings.js"
+    "prepare": "rollup -c rollup.config.release.js"
   },
   "peerDependencies": {
     "@firebase/app-exp": "0.x",

packages-exp/auth-exp/rollup.config.js

@@ -15,134 +15,6 @@
  * limitations under the License.
  */
 
-import strip from '@rollup/plugin-strip';
-import typescriptPlugin from 'rollup-plugin-typescript2';
-import json from 'rollup-plugin-json';
-import typescript from 'typescript';
-import pkg from './package.json';
+import { getConfig } from './rollup.config.shared';
 
-const deps = Object.keys(
-  Object.assign({}, pkg.peerDependencies, pkg.dependencies)
-);
-
-/**
- * Common plugins for all builds
- */
-const commonPlugins = [
-  json(),
-  strip({
-    functions: ['debugAssert.*']
-  })
-];
-
-/**
- * ES5 Builds
- */
-const es5BuildPlugins = [
-  ...commonPlugins,
-  typescriptPlugin({
-    typescript
-  })
-];
-
-const es5Builds = [
-  /**
-   * Browser Builds
-   */
-  {
-    input: {
-      index: 'index.ts',
-      internal: 'internal/index.ts'
-    },
-    output: [{ dir: 'dist/esm5', format: 'esm', sourcemap: true }],
-    plugins: es5BuildPlugins,
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  },
-  /**
-   * Web Worker Build (compiled without DOM)
-   */
-  {
-    input: 'index.webworker.ts',
-    output: [{ file: pkg.webworker, format: 'es', sourcemap: true }],
-    plugins: [
-      ...commonPlugins,
-      typescriptPlugin({
-        typescript,
-        tsconfigOverride: {
-          compilerOptions: {
-            lib: [
-              // Remove dom after we figure out why navigator stuff doesn't exist
-              'dom',
-              'es2015',
-              'webworker'
-            ]
-          }
-        }
-      })
-    ],
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  },
-  /**
-   * Node.js Build
-   */
-  {
-    input: {
-      index: 'index.node.ts',
-      internal: 'internal/index.ts'
-    },
-    output: [{ dir: 'dist/node', format: 'cjs', sourcemap: true }],
-    plugins: es5BuildPlugins,
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  },
-  /**
-   * React Native Builds
-   */
-  {
-    input: {
-      index: 'index.rn.ts',
-      internal: 'internal/index.ts'
-    },
-    output: [{ dir: 'dist/rn', format: 'cjs', sourcemap: true }],
-    plugins: es5BuildPlugins,
-    external: id =>
-      [...deps, 'react-native'].some(
-        dep => id === dep || id.startsWith(`${dep}/`)
-      )
-  }
-];
-
-/**
- * ES2017 Builds
- */
-const es2017BuildPlugins = [
-  ...commonPlugins,
-  typescriptPlugin({
-    typescript,
-    tsconfigOverride: {
-      compilerOptions: {
-        target: 'es2017'
-      }
-    }
-  })
-];
-
-const es2017Builds = [
-  /**
-   *  Browser Builds
-   */
-  {
-    input: {
-      index: 'index.ts',
-      internal: 'internal/index.ts'
-    },
-    output: {
-      dir: 'dist/esm2017',
-      format: 'es',
-      sourcemap: true
-    },
-    plugins: es2017BuildPlugins,
-    external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
-  }
-];
-
-export default [...es5Builds, ...es2017Builds];
+export default getConfig({ isReleaseBuild: false });

packages-exp/auth-exp/rollup.config.release.js

@@ -0,0 +1,20 @@
+/**
+ * @license
+ * Copyright 2019 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { getConfig } from './rollup.config.shared';
+
+export default getConfig({ isReleaseBuild: true });