Skip to content

Commit 6094153

Browse files
committed
Even more feedbacks.
1 parent b6b261b commit 6094153

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

packages/firestore/src/core/bundle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export function bundleSuccessProgress(
143143
export class BundleLoadResult {
144144
constructor(
145145
readonly progress: firestore.LoadBundleTaskProgress,
146-
readonly changedDocs?: MaybeDocumentMap
146+
readonly changedDocs: MaybeDocumentMap
147147
) {}
148148
}
149149

packages/firestore/src/core/sync_engine.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,15 +1432,13 @@ async function loadBundleImpl(
14321432
}
14331433

14341434
const result = await loader.complete();
1435-
if (result.changedDocs) {
1436-
// TODO(b/160876443): This currently raises snapshots with
1437-
// `fromCache=false` if users already listen to some queries and bundles
1438-
// has newer version.
1439-
await syncEngine.emitNewSnapsAndNotifyLocalStore(
1440-
result.changedDocs,
1441-
/* remoteEvent */ undefined
1442-
);
1443-
}
1435+
// TODO(b/160876443): This currently raises snapshots with
1436+
// `fromCache=false` if users already listen to some queries and bundles
1437+
// has newer version.
1438+
await syncEngine.emitNewSnapsAndNotifyLocalStore(
1439+
result.changedDocs,
1440+
/* remoteEvent */ undefined
1441+
);
14441442

14451443
// Save metadata, so loading the same bundle will skip.
14461444
await saveBundle(syncEngine.localStore, metadata);

0 commit comments

Comments
 (0)