Skip to content

Commit 62c58ba

Browse files
authored
Merge 6e74b6c into d1ae4de
2 parents d1ae4de + 6e74b6c commit 62c58ba

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

packages-exp/auth-compat-exp/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
"build:release": "rollup -c rollup.config.release.js && yarn add-compat-overloads",
1919
"dev": "rollup -c -w",
2020
"test": "run-p lint test:all",
21-
"test:all": "run-p test:browser test:node",
21+
"test:all": "run-p test:browser test:node test:integration",
2222
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
2323
"test:browser": "karma start --single-run",
2424
"test:browser:integration": "karma start --single-run --integration",
2525
"test:node": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts",
2626
"test:node:integration": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --integration",
2727
"test:webdriver": "rollup -c test/integration/webdriver/static/rollup.config.js && ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --webdriver",
28-
"test:integration": "run-s test:browser:integration test:node:integration test:webdriver",
28+
"test:integration": "firebase emulators:exec --project demo-emulatedproject --only auth \"run-s test:browser:integration test:node:integration test:webdriver\"",
2929
"add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../auth-exp/dist/auth-exp-public.d.ts -o dist/auth-compat-exp/index.d.ts -a -r Auth:types.FirebaseAuth -r User:types.User -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/auth"
3030
},
3131
"peerDependencies": {
@@ -65,4 +65,4 @@
6565
"reportDir": "./coverage/node"
6666
},
6767
"esm5": "dist/index.esm.js"
68-
}
68+
}

packages-exp/auth-compat-exp/src/phone_auth_provider.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@ import * as exp from '@firebase/auth-exp/internal';
1919
import * as compat from '@firebase/auth-types';
2020
import firebase from '@firebase/app-compat';
2121
import { Compat } from '@firebase/util';
22+
import { unwrap } from './wrap';
2223

2324
export class PhoneAuthProvider
24-
implements compat.PhoneAuthProvider, Compat<exp.PhoneAuthProvider> {
25+
implements compat.PhoneAuthProvider, Compat<exp.PhoneAuthProvider>
26+
{
2527
providerId = 'phone';
2628
readonly _delegate: exp.PhoneAuthProvider;
2729

packages-exp/auth-compat-exp/test/integration/webdriver/static/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ window.legacyAuth = null;
4141
// calls this function after that injection.
4242
window.startAuth = async () => {
4343
// Make sure we haven't confused our firebase with the old firebase
44-
if (!firebase.SDK_VERSION.startsWith('0.9')) {
44+
if (!firebase.SDK_VERSION.startsWith('9.')) {
4545
throw new Error(
4646
'Using legacy SDK version instead of compat version ' +
4747
firebase.SDK_VERSION

0 commit comments

Comments
 (0)