Add more tests

Author: avolkovi

packages-exp/auth-exp/src/core/strategies/anonymous.test.ts

@@ -15,10 +15,14 @@
  * limitations under the License.
  */
 
-import { OperationType, ProviderId, SignInMethod } from '@firebase/auth-types-exp';
+import {
+  OperationType,
+  ProviderId,
+  SignInMethod
+} from '@firebase/auth-types-exp';
 import { expect } from 'chai';
 import { mockEndpoint } from '../../../test/api/helper';
-import { mockAuth } from '../../../test/mock_auth';
+import { mockAuth, testUser } from '../../../test/mock_auth';
 import * as mockFetch from '../../../test/mock_fetch';
 import { Endpoint } from '../../api';
 import { APIUserInfo } from '../../api/account_management/account';
@@ -55,8 +59,37 @@ describe('core/strategies/anonymous', () => {
       expect(user.isAnonymous).to.be.true;
     });
 
-    context('already signed in anonymousl', () => {});
+    context('already signed in anonymously', () => {
+      it('should return the current user', async () => {
+        const userCredential = await signInAnonymously(mockAuth);
+        expect(userCredential.user.isAnonymous).to.be.true;
 
-    context('already signed in with a non-anonymous account', () => {});
+        const { credential, user, operationType } = await signInAnonymously(
+          mockAuth
+        );
+        expect(credential?.providerId).to.eq(ProviderId.ANONYMOUS);
+        expect(credential?.signInMethod).to.eq(SignInMethod.ANONYMOUS);
+        expect(operationType).to.eq(OperationType.SIGN_IN);
+        expect(user.uid).to.eq(userCredential.user.uid);
+        expect(user.isAnonymous).to.be.true;
+      });
+    });
+
+    context('already signed in with a non-anonymous account', () => {
+      it('should sign in as a new user user', async () => {
+        const fakeUser = testUser('other-uid');
+        await mockAuth.updateCurrentUser(fakeUser);
+        expect(fakeUser.isAnonymous).to.be.false;
+
+        const { credential, user, operationType } = await signInAnonymously(
+          mockAuth
+        );
+        expect(credential?.providerId).to.eq(ProviderId.ANONYMOUS);
+        expect(credential?.signInMethod).to.eq(SignInMethod.ANONYMOUS);
+        expect(operationType).to.eq(OperationType.SIGN_IN);
+        expect(user.uid).to.not.eq(fakeUser.uid);
+        expect(user.isAnonymous).to.be.true;
+      });
+    });
   });
 });

packages-exp/auth-exp/src/core/user/user_credential_impl.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { OperationType, UserCredential } from '@firebase/auth-types-exp';
+import { OperationType, UserCredential, ProviderId } from '@firebase/auth-types-exp';
 import { Auth } from '../../model/auth';
 import { AuthCredential } from '../../model/auth_credential';
 import { IdTokenResponse } from '../../model/id_token';
@@ -35,7 +35,7 @@ export class UserCredentialImpl implements UserCredential {
     operationType: OperationType,
     idTokenResponse: IdTokenResponse
   ): Promise<UserCredential> {
-    const user = await UserImpl._fromIdTokenResponse(auth, idTokenResponse);
+    const user = await UserImpl._fromIdTokenResponse(auth, idTokenResponse, credential?.providerId === ProviderId.ANONYMOUS);
     const userCred = new UserCredentialImpl(user, credential, operationType);
     // TODO: handle additional user info
     // updateAdditionalUserInfoFromIdTokenResponse(userCred, idTokenResponse);

packages-exp/auth-exp/src/core/user/user_impl.ts

@@ -35,6 +35,7 @@ export interface UserParameters {
   email?: string;
   phoneNumber?: string;
   photoURL?: string;
+  isAnonymous?: boolean;
 }
 
 function assertStringOrUndefined(
@@ -65,7 +66,7 @@ export class UserImpl implements User {
   email: string | null;
   phoneNumber: string | null;
   photoURL: string | null;
-  isAnonymous = false;
+  isAnonymous: boolean = false;
 
   constructor({ uid, auth, stsTokenManager, ...opt }: UserParameters) {
     this.uid = uid;
@@ -75,6 +76,7 @@ export class UserImpl implements User {
     this.email = opt.email || null;
     this.phoneNumber = opt.phoneNumber || null;
     this.photoURL = opt.photoURL || null;
+    this.isAnonymous = opt.isAnonymous || false;
   }
 
   async getIdToken(forceRefresh?: boolean): Promise<string> {
@@ -161,7 +163,8 @@ export class UserImpl implements User {
    */
   static async _fromIdTokenResponse(
     auth: Auth,
-    idTokenResponse: IdTokenResponse
+    idTokenResponse: IdTokenResponse,
+    isAnonymous: boolean = false
   ): Promise<User> {
     const stsTokenManager = new StsTokenManager();
     stsTokenManager.updateFromServerResponse(idTokenResponse);
@@ -170,7 +173,8 @@ export class UserImpl implements User {
     const user = new UserImpl({
       uid: idTokenResponse.localId,
       auth,
-      stsTokenManager
+      stsTokenManager,
+      isAnonymous
     });
 
     // Updates the user info and data and resolves with a user instance.