Set typescript strict option to true for functions and testing (#1915)

Enable typescript script option

Author: hsubox76

packages/firebase/tsconfig.json

@@ -3,7 +3,8 @@
   "compilerOptions": {
     "outDir": "dist",
     "declaration": false,
-    "allowSyntheticDefaultImports": true
+    "allowSyntheticDefaultImports": true,
+    "strict": true
   },
   "exclude": [
     "dist/**/*"

packages/functions/src/api/service.ts

@@ -71,7 +71,7 @@ export class Service implements FirebaseFunctions, FirebaseService {
   private readonly serializer = new Serializer();
   private emulatorOrigin: string | null = null;
   private cancelAllRequests: Promise<void>;
-  private deleteService: Function;
+  private deleteService!: Function;
 
   /**
    * Creates a new Functions service for the given app and (optional) region.

packages/functions/tsconfig.json

@@ -1,7 +1,8 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist"
+    "outDir": "dist",
+    "strict": true
   },
   "exclude": [
     "dist/**/*"

packages/testing/test/database.test.ts

@@ -87,14 +87,17 @@ describe('Testing Module Tests', function() {
   });
 
   it('loadDatabaseRules() throws if no databaseName or rules', async function() {
-    await expect(firebase.loadDatabaseRules.bind(null, {})).to.throw(
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    await expect((firebase as any).loadDatabaseRules.bind(null, {})).to.throw(
       /databaseName not specified/
     );
-    await expect(firebase.loadDatabaseRules.bind(null, {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    await expect((firebase as any).loadDatabaseRules.bind(null, {
       databaseName: 'foo'
     }) as Promise<void>).to.throw(/must provide rules/);
     await expect(
-      firebase.loadDatabaseRules.bind(null, { rules: '{}' })
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      (firebase as any).loadDatabaseRules.bind(null, { rules: '{}' })
     ).to.throw(/databaseName not specified/);
   });
 

packages/testing/tsconfig.json

@@ -1,7 +1,8 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist"
+    "outDir": "dist",
+    "strict": true
   },
   "exclude": [
     "dist/**/*"