Fix linter issues

Author: sam-gc

packages-exp/auth-compat-exp/src/user_credential.ts

@@ -42,7 +42,7 @@ function modifyError(auth: exp.Auth, e: FirebaseError): void {
     const mfaErr = e as compat.MultiFactorError;
     mfaErr.resolver = new MultiFactorResolver(
       auth,
-      exp.getMultiFactorResolver(auth, e as any)
+      exp.getMultiFactorResolver(auth, e as exp.MultiFactorError)
     );
   } else if (response) {
     const credential = credentialFromObject(e);
@@ -120,7 +120,7 @@ function credentialFromObject(
       }
       // TODO(avolkovi): uncomment this and get it working with SAML & OIDC
       if (pendingToken) {
-        if (providerId.indexOf('saml.') == 0) {
+        if (providerId.startsWith('saml.')) {
           return exp.SAMLAuthCredential._create(providerId, pendingToken);
         } else {
           // OIDC and non-default providers excluding Twitter.

packages-exp/auth-exp/src/mfa/mfa_resolver.ts

@@ -19,7 +19,8 @@ import {
   Auth,
   MultiFactorResolver,
   OperationType,
-  UserCredential
+  UserCredential,
+  MultiFactorError
 } from '../model/public_types';
 
 import { _castAuth } from '../core/auth/auth_impl';
@@ -28,7 +29,7 @@ import { UserCredentialImpl } from '../core/user/user_credential_impl';
 import { _assert, _fail } from '../core/util/assert';
 import { UserCredentialInternal } from '../model/user';
 import { MultiFactorAssertionImpl } from './mfa_assertion';
-import { MultiFactorError } from './mfa_error';
+import { MultiFactorError as MultiFactorErrorInternal } from './mfa_error';
 import { MultiFactorInfoImpl } from './mfa_info';
 import { MultiFactorSessionImpl } from './mfa_session';
 
@@ -44,7 +45,7 @@ export class MultiFactorResolverImpl implements MultiFactorResolver {
   /** @internal */
   static _fromError(
     authExtern: Auth,
-    error: MultiFactorError
+    error: MultiFactorErrorInternal
   ): MultiFactorResolverImpl {
     const auth = _castAuth(authExtern);
     const hints = (error.serverResponse.mfaInfo || []).map(enrollment =>
@@ -124,7 +125,7 @@ export function getMultiFactorResolver(
   auth: Auth,
   error: MultiFactorError
 ): MultiFactorResolver {
-  const errorInternal = error as MultiFactorError;
+  const errorInternal = error as MultiFactorErrorInternal;
   _assert(error.operationType, auth, AuthErrorCode.ARGUMENT_ERROR);
   _assert(
     errorInternal.serverResponse?.mfaPendingCredential,

packages-exp/auth-exp/test/integration/webdriver/persistence.test.ts

@@ -129,7 +129,7 @@ browserDescribe('WebDriver persistence test', driver => {
       expect(await driver.getUserSnapshot()).to.contain({ uid });
     });
 
-    it.only('fall back to in-memory if neither indexedDB or localStorage is present', async () => {
+    it('fall back to in-memory if neither indexedDB or localStorage is present', async () => {
       await driver.webDriver.navigate().refresh();
       // Simulate browsers that do not support indexedDB or localStorage.
       await driver.webDriver.executeScript(