Keep INDEXING_ENABLED flag since Web implementation is still incomplete.

Author: tom-andersen

packages/firestore/src/local/indexeddb_schema.ts

@@ -28,6 +28,9 @@ import {
 import { EncodedResourcePath } from './encoded_resource_path';
 import { DbTimestampKey } from './indexeddb_sentinels';
 
+// TODO(indexing): Remove this constant
+export const INDEXING_ENABLED = false;
+
 export const INDEXING_SCHEMA_VERSION = 15;
 
 /**
@@ -55,7 +58,7 @@ export const INDEXING_SCHEMA_VERSION = 15;
  * 15. Add indexing support.
  */
 
-export const SCHEMA_VERSION = INDEXING_SCHEMA_VERSION;
+export const SCHEMA_VERSION = INDEXING_ENABLED ? INDEXING_SCHEMA_VERSION : 14;
 
 /**
  * Wrapper class to store timestamps (seconds and nanos) in IndexedDb objects.

packages/firestore/src/local/query_engine.ts

@@ -43,6 +43,7 @@ import { Iterable } from '../util/misc';
 import { SortedSet } from '../util/sorted_set';
 
 import { IndexManager, IndexType } from './index_manager';
+import { INDEXING_ENABLED } from './indexeddb_schema';
 import { LocalDocumentsView } from './local_documents_view';
 import { PersistencePromise } from './persistence_promise';
 import { PersistenceTransaction } from './persistence_transaction';
@@ -133,6 +134,10 @@ export class QueryEngine {
     transaction: PersistenceTransaction,
     query: Query
   ): PersistencePromise<DocumentMap | null> {
+    if (!INDEXING_ENABLED) {
+      return PersistencePromise.resolve<DocumentMap | null>(null);
+    }
+
     if (queryMatchesAllDocuments(query)) {
       // Queries that match all documents don't benefit from using
       // key-based lookups. It is more efficient to scan all documents in a

packages/firestore/test/unit/local/query_engine.test.ts

@@ -30,7 +30,10 @@ import { SnapshotVersion } from '../../../src/core/snapshot_version';
 import { View } from '../../../src/core/view';
 import { DocumentOverlayCache } from '../../../src/local/document_overlay_cache';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
-import { INDEXING_SCHEMA_VERSION } from '../../../src/local/indexeddb_schema';
+import {
+  INDEXING_ENABLED,
+  INDEXING_SCHEMA_VERSION
+} from '../../../src/local/indexeddb_schema';
 import { LocalDocumentsView } from '../../../src/local/local_documents_view';
 import { MutationQueue } from '../../../src/local/mutation_queue';
 import { Persistence } from '../../../src/local/persistence';
@@ -518,6 +521,10 @@ function genericQueryEngineTest(
     return;
   }
 
+  if (!INDEXING_ENABLED) {
+    return;
+  }
+
   it('combines indexed with non-indexed results', async () => {
     debugAssert(durable, 'Test requires durable persistence');