@@ -34,21 +34,23 @@ const bumpRank: Record<string, number> = {
34
34
35
35
/**
36
36
* Get highest bump that isn't the main firebase package, return
37
- // numerical rank and bump text.
37
+ // numerical rank, bump text, package name .
38
38
*/
39
39
function getHighestBump ( changesetPackages : Record < string , string > ) {
40
40
let highestBump = bumpRank . patch ;
41
41
let highestBumpText = 'patch' ;
42
+ let bumpPackage = '' ;
42
43
for ( const pkgName in changesetPackages ) {
43
44
if (
44
45
pkgName !== 'firebase' &&
45
46
bumpRank [ changesetPackages [ pkgName ] ] > highestBump
46
47
) {
47
48
highestBump = bumpRank [ changesetPackages [ pkgName ] ] ;
48
49
highestBumpText = changesetPackages [ pkgName ] ;
50
+ bumpPackage = pkgName ;
49
51
}
50
52
}
51
- return { highestBump, bumpText : highestBumpText } ;
53
+ return { highestBump, bumpText : highestBumpText , bumpPackage } ;
52
54
}
53
55
54
56
/**
@@ -167,17 +169,18 @@ async function main() {
167
169
168
170
// Check for packages with a minor or major bump where 'firebase' hasn't been
169
171
// included.
170
- const { highestBump, bumpText } = getHighestBump ( changesetPackages ) ;
171
- console . log ( highestBump , bumpText ) ;
172
+ const { highestBump, bumpText, bumpPackage } = getHighestBump (
173
+ changesetPackages
174
+ ) ;
172
175
if ( highestBump > bumpRank . patch ) {
173
176
if ( changesetPackages [ 'firebase' ] == null ) {
174
177
errors . push (
175
- `- There is a package with a ${ bumpText } bump which requires an ` +
178
+ `- Package ${ bumpPackage } has a ${ bumpText } bump which requires an ` +
176
179
`additional line to bump the main "firebase" package to ${ bumpText } .`
177
180
) ;
178
181
} else if ( bumpRank [ changesetPackages [ 'firebase' ] ] < highestBump ) {
179
182
errors . push (
180
- `- There is a package with a ${ bumpText } bump. ` +
183
+ `- Package ${ bumpPackage } has a ${ bumpText } bump. ` +
181
184
`Increase the bump for the main "firebase" package to ${ bumpText } .`
182
185
) ;
183
186
}
0 commit comments