WIP: add in dev time circular dep detection

Author: jshcrowthe

gulp/tasks/dev.js

@@ -19,6 +19,7 @@ const config = require('../config');
 const webpack = require('webpack');
 const merge = require('merge2');
 const WebpackDevServer = require('webpack-dev-server');
+const CircularDependencyPlugin = require('circular-dependency-plugin');
 
 // Ensure that the test tasks get set up
 const testFxns = require('./test');
@@ -64,6 +65,14 @@ function runDevServer(callback) {
     resolve: {
       extensions: [".tsx", ".ts", ".js"]
     },
+    plugins: [
+      new CircularDependencyPlugin({
+        // exclude detection of files based on a RegExp
+        exclude: /node_modules/,
+        // add errors to webpack instead of warnings
+        failOnError: true
+      })
+    ],
     devtool: 'inline-source-map',
   };
   // Start a webpack-dev-server

package.json

@@ -39,6 +39,7 @@
     "babel-preset-env": "^1.2.1",
     "chai": "^3.5.0",
     "child-process-promise": "^2.2.1",
+    "circular-dependency-plugin": "^3.0.0",
     "cz-customizable": "^5.0.0",
     "filesize": "^3.5.6",
     "git-rev-sync": "^1.9.0",

yarn.lock

@@ -1306,6 +1306,10 @@ cipher-base@^1.0.0, cipher-base@^1.0.1:
   dependencies:
     inherits "^2.0.1"
 
+circular-dependency-plugin@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/circular-dependency-plugin/-/circular-dependency-plugin-3.0.0.tgz#9b68692e35b0e3510998d0164b6ae5011bea5760"
+
 cli-cursor@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/cli-cursor/-/cli-cursor-1.0.2.tgz#64da3f7d56a54412e59794bd62dc35295e8f2987"