fix lint errors

Author: Feiyang1

packages/firestore/compat/config.ts

@@ -15,8 +15,9 @@
  * limitations under the License.
  */
 
-import { FirebaseNamespace } from '@firebase/app-types';
+// eslint-disable-next-line import/no-extraneous-dependencies
 import { FirebaseApp } from '@firebase/app-compat';
+import { FirebaseNamespace } from '@firebase/app-types';
 import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { Component, ComponentType } from '@firebase/component';
 
@@ -28,7 +29,7 @@ import {
   Timestamp,
   FieldValue
 } from '../exp/index'; // import from the exp public API
-
+import { Blob } from '../src/api/blob';
 import {
   Firestore,
   Transaction,
@@ -42,8 +43,6 @@ import {
   setLogLevel
 } from '../src/api/database';
 
-import { Blob } from '../src/api/blob';
-
 const firestoreNamespace = {
   Firestore,
   GeoPoint,

packages/firestore/compat/index.bundle.ts

@@ -15,12 +15,12 @@
  * limitations under the License.
  */
 
-import { Firestore, Query } from '../src/api/database';
 import {
   loadBundle as expLoadBundle,
   namedQuery as expNamedQuery,
   LoadBundleTask
 } from '../exp/index';
+import { Firestore, Query } from '../src/api/database';
 
 export function loadBundle(
   this: Firestore,

packages/firestore/compat/index.memory.ts

@@ -15,12 +15,13 @@
  * limitations under the License.
  */
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
+import { name, version } from '../package.json';
 import { Firestore, MemoryPersistenceProvider } from '../src/api/database';
 
-import { name, version } from '../package.json';
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -37,4 +38,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version);
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/compat/index.node.memory.ts

@@ -15,11 +15,13 @@
  * limitations under the License.
  */
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
 import { name, version } from '../package.json';
 import { Firestore, MemoryPersistenceProvider } from '../src/api/database';
+
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -37,4 +39,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version, 'node');
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/compat/index.node.ts

@@ -14,11 +14,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
 import { name, version } from '../package.json';
 import { Firestore, IndexedDbPersistenceProvider } from '../src/api/database';
+
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -36,4 +39,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version, 'node');
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/compat/index.rn.memory.ts

@@ -15,11 +15,13 @@
  * limitations under the License.
  */
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
-import { Firestore, MemoryPersistenceProvider } from '../src/api/database';
 import { name, version } from '../package.json';
+import { Firestore, MemoryPersistenceProvider } from '../src/api/database';
+
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -37,4 +39,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version, 'rn');
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/compat/index.rn.ts

@@ -14,11 +14,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
-import { Firestore, IndexedDbPersistenceProvider } from '../src/api/database';
 import { name, version } from '../package.json';
+import { Firestore, IndexedDbPersistenceProvider } from '../src/api/database';
+
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -36,4 +39,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version, 'rn');
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/compat/index.ts

@@ -15,11 +15,13 @@
  * limitations under the License.
  */
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 
-import { Firestore, IndexedDbPersistenceProvider } from '../src/api/database';
 import { name, version } from '../package.json';
+import { Firestore, IndexedDbPersistenceProvider } from '../src/api/database';
+
 import { configureForFirebase } from './config';
 
 import '../register-module';
@@ -37,4 +39,4 @@ export function registerFirestore(instance: FirebaseNamespace): void {
   instance.registerVersion(name, version);
 }
 
-registerFirestore(firebase as any);
+registerFirestore((firebase as unknown) as FirebaseNamespace);

packages/firestore/src/api/database.ts

@@ -100,8 +100,8 @@ import {
   WriteBatch as ExpWriteBatch,
   AbstractUserDataWriter
 } from '../../exp/index'; // import from the exp public API
-
 import { DatabaseId } from '../core/database_info';
+import { UntypedFirestoreDataConverter } from '../lite/user_data_reader';
 import { DocumentKey } from '../model/document_key';
 import { FieldPath, ResourcePath } from '../model/path';
 import { debugAssert } from '../util/assert';
@@ -123,7 +123,6 @@ import {
   NextFn,
   PartialObserver
 } from './observer';
-import { UntypedFirestoreDataConverter } from '../lite/user_data_reader';
 
 /**
  * A persistence provider for either memory-only or IndexedDB persistence.

packages/firestore/src/exp/reference_impl.ts

@@ -23,14 +23,6 @@ import {
   NextFn,
   PartialObserver
 } from '../api/observer';
-import {
-  newUserDataReader,
-  ParsedUpdateData,
-  parseSetData,
-  parseUpdateData,
-  parseUpdateVarargs
-} from '../lite/user_data_reader';
-import { AbstractUserDataWriter } from '../lite/user_data_writer';
 import {
   firestoreClientAddSnapshotsInSyncListener,
   firestoreClientGetDocumentFromLocalCache,
@@ -54,6 +46,14 @@ import {
   UpdateData
 } from '../lite/reference';
 import { applyFirestoreDataConverter } from '../lite/reference_impl';
+import {
+  newUserDataReader,
+  ParsedUpdateData,
+  parseSetData,
+  parseUpdateData,
+  parseUpdateVarargs
+} from '../lite/user_data_reader';
+import { AbstractUserDataWriter } from '../lite/user_data_writer';
 import { Document } from '../model/document';
 import { DeleteMutation, Mutation, Precondition } from '../model/mutation';
 import { debugAssert } from '../util/assert';

packages/firestore/src/exp/snapshot.ts

@@ -15,8 +15,6 @@
  * limitations under the License.
  */
 
-import { UntypedFirestoreDataConverter } from '../lite/user_data_reader';
-import { AbstractUserDataWriter } from '../lite/user_data_writer';
 import { newQueryComparator } from '../core/query';
 import { ChangeType, ViewSnapshot } from '../core/view_snapshot';
 import { FieldPath } from '../lite/field_path';
@@ -26,6 +24,8 @@ import {
   fieldPathFromArgument,
   FirestoreDataConverter as LiteFirestoreDataConverter
 } from '../lite/snapshot';
+import { UntypedFirestoreDataConverter } from '../lite/user_data_reader';
+import { AbstractUserDataWriter } from '../lite/user_data_writer';
 import { Document } from '../model/document';
 import { DocumentKey } from '../model/document_key';
 import { debugAssert, fail } from '../util/assert';

packages/firestore/src/lite/field_value_impl.ts

@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import { FieldValue } from './field_value';
 import {
   ArrayRemoveFieldValueImpl,
   ArrayUnionFieldValueImpl,
@@ -23,8 +24,6 @@ import {
   ServerTimestampFieldValueImpl
 } from './user_data_reader';
 
-import { FieldValue } from './field_value';
-
 /**
  * Returns a sentinel for use with {@link updateDoc} or
  * {@link setDoc} with `{merge: true}` to mark a field for deletion.

packages/firestore/src/lite/query.ts

@@ -16,11 +16,6 @@
  */
 
 import { Compat } from '../api/compat';
-import {
-  newUserDataReader,
-  parseQueryValue,
-  UserDataReader
-} from './user_data_reader';
 import { DatabaseId } from '../core/database_info';
 import {
   findFilterOperator,
@@ -61,6 +56,11 @@ import {
 import { FieldPath } from './field_path';
 import { DocumentReference, Query } from './reference';
 import { DocumentSnapshot, fieldPathFromArgument } from './snapshot';
+import {
+  newUserDataReader,
+  parseQueryValue,
+  UserDataReader
+} from './user_data_reader';
 
 export function validateHasExplicitOrderByForLimitToLast(
   query: InternalQuery

packages/firestore/src/lite/reference_impl.ts

@@ -21,15 +21,6 @@ import {
 } from '@firebase/firestore-types';
 
 import { Compat } from '../api/compat';
-import {
-  newUserDataReader,
-  ParsedUpdateData,
-  parseSetData,
-  parseUpdateData,
-  parseUpdateVarargs,
-  UntypedFirestoreDataConverter
-} from './user_data_reader';
-import { AbstractUserDataWriter } from './user_data_writer';
 import { hasLimitToLast } from '../core/query';
 import { Document } from '../model/document';
 import { DeleteMutation, Precondition } from '../model/mutation';
@@ -60,6 +51,15 @@ import {
   QueryDocumentSnapshot,
   QuerySnapshot
 } from './snapshot';
+import {
+  newUserDataReader,
+  ParsedUpdateData,
+  parseSetData,
+  parseUpdateData,
+  parseUpdateVarargs,
+  UntypedFirestoreDataConverter
+} from './user_data_reader';
+import { AbstractUserDataWriter } from './user_data_writer';
 
 /**
  * Converts custom model object of type T into DocumentData by applying the

packages/firestore/src/lite/snapshot.ts

@@ -16,11 +16,6 @@
  */
 
 import { Compat } from '../api/compat';
-import {
-  fieldPathFromDotSeparatedString,
-  UntypedFirestoreDataConverter
-} from './user_data_reader';
-import { AbstractUserDataWriter } from './user_data_writer';
 import { Document } from '../model/document';
 import { DocumentKey } from '../model/document_key';
 import { FieldPath as InternalFieldPath } from '../model/path';
@@ -35,6 +30,11 @@ import {
   queryEqual,
   SetOptions
 } from './reference';
+import {
+  fieldPathFromDotSeparatedString,
+  UntypedFirestoreDataConverter
+} from './user_data_reader';
+import { AbstractUserDataWriter } from './user_data_writer';
 
 /**
  * Converter used by `withConverter()` to transform user objects of type `T`

packages/firestore/src/lite/transaction.ts

@@ -16,13 +16,6 @@
  */
 
 import { Compat } from '../api/compat';
-import {
-  newUserDataReader,
-  parseSetData,
-  parseUpdateData,
-  parseUpdateVarargs,
-  UserDataReader
-} from './user_data_reader';
 import { Transaction as InternalTransaction } from '../core/transaction';
 import { TransactionRunner } from '../core/transaction_runner';
 import { Document, MaybeDocument, NoDocument } from '../model/document';
@@ -40,6 +33,13 @@ import {
   LiteUserDataWriter
 } from './reference_impl';
 import { DocumentSnapshot } from './snapshot';
+import {
+  newUserDataReader,
+  parseSetData,
+  parseUpdateData,
+  parseUpdateVarargs,
+  UserDataReader
+} from './user_data_reader';
 import { validateReference } from './write_batch';
 
 // TODO(mrschmidt) Consider using `BaseTransaction` as the base class in the

packages/firestore/src/lite/user_data_reader.ts

@@ -21,12 +21,9 @@ import {
   SetOptions
 } from '@firebase/firestore-types';
 
+import { Compat } from '../api/compat';
+import { ParseContext } from '../api/parse_context';
 import { DatabaseId } from '../core/database_info';
-import { Bytes } from './bytes';
-import { FirebaseFirestore } from './database';
-import { FieldPath } from './field_path';
-import { FieldValue } from './field_value';
-import { DocumentReference } from './reference';
 import { DocumentKey } from '../model/document_key';
 import { FieldMask } from '../model/field_mask';
 import {
@@ -61,9 +58,12 @@ import { Code, FirestoreError } from '../util/error';
 import { isPlainObject, valueDescription } from '../util/input_validation';
 import { Dict, forEach, isEmpty } from '../util/obj';
 
-import { Compat } from '../api/compat';
+import { Bytes } from './bytes';
+import { FirebaseFirestore } from './database';
+import { FieldPath } from './field_path';
+import { FieldValue } from './field_value';
 import { GeoPoint } from './geo_point';
-import { ParseContext } from '../api/parse_context';
+import { DocumentReference } from './reference';
 import { Timestamp } from './timestamp';
 
 const RESERVED_FIELD_REGEX = /^__.*__$/;