overload user related functions (#4701)

Author: Feiyang1

packages-exp/auth-compat-exp/index.ts

@@ -26,26 +26,7 @@ import {
   InstantiationMode
 } from '@firebase/component';
 
-import {
-  EmailAuthProvider,
-  EmailAuthProvider_Instance,
-  FacebookAuthProvider,
-  FacebookAuthProvider_Instance,
-  FirebaseAuth as AuthCompat,
-  GithubAuthProvider,
-  GithubAuthProvider_Instance,
-  GoogleAuthProvider,
-  GoogleAuthProvider_Instance,
-  OAuthProvider,
-  PhoneAuthProvider,
-  PhoneAuthProvider_Instance,
-  PhoneMultiFactorGenerator,
-  RecaptchaVerifier,
-  RecaptchaVerifier_Instance,
-  SAMLAuthProvider,
-  TwitterAuthProvider,
-  TwitterAuthProvider_Instance
-} from '@firebase/auth-types';
+import * as types from '@firebase/auth-types';
 import { version } from './package.json';
 import { Auth } from './src/auth';
 import { Persistence } from './src/persistence';
@@ -56,36 +37,36 @@ const AUTH_TYPE = 'auth-compat';
 
 declare module '@firebase/component' {
   interface NameServiceMapping {
-    'auth-compat': AuthCompat;
+    'auth-compat': types.FirebaseAuth;
   }
 }
 
 declare module '@firebase/app-compat' {
   interface FirebaseNamespace {
     auth: {
-      (app?: FirebaseApp): AuthCompat;
-      Auth: typeof AuthCompat;
-      EmailAuthProvider: typeof EmailAuthProvider;
-      EmailAuthProvider_Instance: typeof EmailAuthProvider_Instance;
-      FacebookAuthProvider: typeof FacebookAuthProvider;
-      FacebookAuthProvider_Instance: typeof FacebookAuthProvider_Instance;
-      GithubAuthProvider: typeof GithubAuthProvider;
-      GithubAuthProvider_Instance: typeof GithubAuthProvider_Instance;
-      GoogleAuthProvider: typeof GoogleAuthProvider;
-      GoogleAuthProvider_Instance: typeof GoogleAuthProvider_Instance;
-      OAuthProvider: typeof OAuthProvider;
-      SAMLAuthProvider: typeof SAMLAuthProvider;
-      PhoneAuthProvider: typeof PhoneAuthProvider;
-      PhoneAuthProvider_Instance: typeof PhoneAuthProvider_Instance;
-      PhoneMultiFactorGenerator: typeof PhoneMultiFactorGenerator;
-      RecaptchaVerifier: typeof RecaptchaVerifier;
-      RecaptchaVerifier_Instance: typeof RecaptchaVerifier_Instance;
-      TwitterAuthProvider: typeof TwitterAuthProvider;
-      TwitterAuthProvider_Instance: typeof TwitterAuthProvider_Instance;
+      (app?: FirebaseApp): types.FirebaseAuth;
+      Auth: typeof types.FirebaseAuth;
+      EmailAuthProvider: typeof types.EmailAuthProvider;
+      EmailAuthProvider_Instance: typeof types.EmailAuthProvider_Instance;
+      FacebookAuthProvider: typeof types.FacebookAuthProvider;
+      FacebookAuthProvider_Instance: typeof types.FacebookAuthProvider_Instance;
+      GithubAuthProvider: typeof types.GithubAuthProvider;
+      GithubAuthProvider_Instance: typeof types.GithubAuthProvider_Instance;
+      GoogleAuthProvider: typeof types.GoogleAuthProvider;
+      GoogleAuthProvider_Instance: typeof types.GoogleAuthProvider_Instance;
+      OAuthProvider: typeof types.OAuthProvider;
+      SAMLAuthProvider: typeof types.SAMLAuthProvider;
+      PhoneAuthProvider: typeof types.PhoneAuthProvider;
+      PhoneAuthProvider_Instance: typeof types.PhoneAuthProvider_Instance;
+      PhoneMultiFactorGenerator: typeof types.PhoneMultiFactorGenerator;
+      RecaptchaVerifier: typeof types.RecaptchaVerifier;
+      RecaptchaVerifier_Instance: typeof types.RecaptchaVerifier_Instance;
+      TwitterAuthProvider: typeof types.TwitterAuthProvider;
+      TwitterAuthProvider_Instance: typeof types.TwitterAuthProvider_Instance;
     };
   }
   interface FirebaseApp {
-    auth?(): AuthCompat;
+    auth?(): types.FirebaseAuth;
   }
 }
 

packages-exp/auth-compat-exp/package.json

@@ -27,7 +27,7 @@
     "test:node:integration": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --integration",
     "test:webdriver": "rollup -c test/integration/webdriver/static/rollup.config.js && ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --webdriver",
     "test:integration": "run-s test:browser:integration test:node:integration test:webdriver",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../auth-exp/dist/auth-exp-public.d.ts -o dist/auth-compat-exp/index.d.ts -a -r Auth:AuthCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/auth"
+    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../auth-exp/dist/auth-exp-public.d.ts -o dist/auth-compat-exp/index.d.ts -a -r Auth:types.FirebaseAuth -r User:types.User -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/auth"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"

packages-exp/auth-exp/src/core/user/account_info.ts

@@ -26,11 +26,6 @@ import { UserInternal } from '../../model/user';
 import { _logoutIfInvalidated } from './invalidation';
 import { getModularInstance } from '@firebase/util';
 
-interface Profile {
-  displayName?: string | null;
-  photoURL?: string | null;
-}
-
 /**
  * Updates a user's profile data.
  *
@@ -41,7 +36,10 @@ interface Profile {
  */
 export async function updateProfile(
   user: User,
-  { displayName, photoURL: photoUrl }: Profile
+  {
+    displayName,
+    photoURL: photoUrl
+  }: { displayName?: string | null; photoURL?: string | null }
 ): Promise<void> {
   if (displayName === undefined && photoUrl === undefined) {
     return;