Config firestore integration, test on push

Author: hsubox76

.github/workflows/cross-browser-test.yml

@@ -2,8 +2,8 @@ name: Cross-Browser Test Flow
 
 on:
   push:
-    branches:
-      - master
+    # branches:
+    #   - master
 
 jobs:
   cross-browser-test:

config/karma.saucelabs.js

@@ -31,10 +31,10 @@ if (!testConfigFile) {
  */
 const browserMap = {
   // Desktop
-  // Chrome_Windows: seleniumLauncher('chrome', 'Windows 10', 'latest'),
-  // Firefox_Windows: seleniumLauncher('firefox', 'Windows 10', 'latest'),
-  // Safari_macOS: seleniumLauncher('safari', 'macOS 10.13', 'latest'),
-  // Edge_Windows: seleniumLauncher('MicrosoftEdge', 'Windows 10', 'latest'),
+  Chrome_Windows: seleniumLauncher('chrome', 'Windows 10', 'latest'),
+  Firefox_Windows: seleniumLauncher('firefox', 'Windows 10', 'latest'),
+  Safari_macOS: seleniumLauncher('safari', 'macOS 10.13', 'latest'),
+  Edge_Windows: seleniumLauncher('MicrosoftEdge', 'Windows 10', 'latest'),
   IE_Windows: seleniumLauncher('internet explorer', 'Windows 10', 'latest')
 
   // Mobile
@@ -50,15 +50,16 @@ const packageConfigs = {
     // Messaging currently only supports these browsers.
     browsers: ['Chrome_Windows', 'Firefox_Windows', 'Edge_Windows']
   },
-  // Firestore has large number of IE test failures, need to spend time to fix.
-  // firestore: {
-  //   browsers: [
-  //     'Chrome_Windows',
-  //     'Firefox_Windows',
-  //     'Edge_Windows',
-  //     'Safari_macOS'
-  //   ]
-  // },
+  // Firestore unit tests have OOM problems compiling with Babel for IE.
+  // Firestore integration/firestore tests do run on all browsers.
+  'packages/firestore': {
+    browsers: [
+      'Chrome_Windows',
+      'Firefox_Windows',
+      'Edge_Windows',
+      'Safari_macOS'
+    ]
+  },
   // Installations has IE errors related to `idb` library that need to be figured out.
   installations: {
     browsers: [
@@ -75,11 +76,14 @@ const packageConfigs = {
  *
  * @param {string} packageName Name of package being tested (e.g., "firestore")
  */
-function getSauceLabsBrowsers(packageName) {
-  if (packageConfigs[packageName]) {
+function getSauceLabsBrowsers(packageName, packageType) {
+  const packageConfig =
+    packageConfigs[packageName] ||
+    packageConfigs[`${packageType}/${packageName}`];
+  if (packageConfig) {
     const filteredBrowserMap = {};
     for (const browserKey in browserMap) {
-      if (packageConfigs[packageName].browsers.includes(browserKey)) {
+      if (packageConfig.browsers.includes(browserKey)) {
         filteredBrowserMap[browserKey] = browserMap[browserKey];
       }
     }
@@ -109,10 +113,14 @@ function getPackageLabels() {
  */
 function getTestFiles() {
   let root = path.resolve(__dirname, '..');
-  const { name: packageName } = getPackageLabels();
+  const { name: packageName, type: packageType } = getPackageLabels();
   let patterns = require(path.join(root, testConfigFile)).files;
   let dirname = path.dirname(testConfigFile);
-  return { packageName, files: patterns.map(p => path.join(dirname, p)) };
+  return {
+    packageName,
+    packageType,
+    files: patterns.map(p => path.join(dirname, p))
+  };
 }
 
 function seleniumLauncher(browserName, platform, version) {
@@ -156,8 +164,8 @@ function appiumLauncher(
 }
 
 module.exports = function(config) {
-  const { packageName, files: testFiles } = getTestFiles();
-  const sauceLabsBrowsers = getSauceLabsBrowsers(packageName);
+  const { packageName, packageType, files: testFiles } = getTestFiles();
+  const sauceLabsBrowsers = getSauceLabsBrowsers(packageName, packageType);
 
   const sauceLabsConfig = {
     tunnelIdentifier: process.env.TRAVIS_JOB_NUMBER + '-' + packageName,

packages/polyfill/index.ts

@@ -38,3 +38,4 @@ import 'core-js/features/symbol/iterator';
 import 'core-js/features/map';
 import 'core-js/features/set';
 import 'core-js/features/number/is-integer';
+import 'core-js/features/number/is-nan';

scripts/run_saucelabs.js

@@ -74,16 +74,16 @@ async function runTest(testFile) {
     }
   }
   if (testFile.includes('integration/firestore')) {
-    // console.log(
-    //   chalk`{blue Generating memory-only build for integration/firestore.}`
-    // );
-    // await spawn('yarn', ['--cwd', 'integration/firestore', 'build:memory'], {
-    //   stdio: 'inherit'
-    // });
-    // console.log(
-    //   chalk`{blue Running tests on memory-only build for integration/firestore.}`
-    // );
-    // const exitCode1 = await runKarma(testFile, 'memory');
+    console.log(
+      chalk`{blue Generating memory-only build for integration/firestore.}`
+    );
+    await spawn('yarn', ['--cwd', 'integration/firestore', 'build:memory'], {
+      stdio: 'inherit'
+    });
+    console.log(
+      chalk`{blue Running tests on memory-only build for integration/firestore.}`
+    );
+    const exitCode1 = await runKarma(testFile, 'memory');
     console.log(
       chalk`{blue Generating persistence build for integration/firestore.}`
     );
@@ -96,8 +96,7 @@ async function runTest(testFile) {
       chalk`{blue Running tests on persistence build for integration/firestore.}`
     );
     const exitCode2 = await runKarma(testFile, 'persistence');
-    // return Math.max(exitCode1, exitCode2);
-    return exitCode2;
+    return Math.max(exitCode1, exitCode2);
   } else {
     return runKarma(testFile);
   }