Skip to content

Commit 6ded341

Browse files
committed
Feedback
1 parent 20b6831 commit 6ded341

File tree

2 files changed

+28
-21
lines changed

2 files changed

+28
-21
lines changed

packages/firestore/test/unit/api/geo_point.test.ts

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,21 @@ describe('GeoPoint', () => {
102102
});
103103

104104
it('serializes to JSON', () => {
105-
expect(JSON.stringify(new GeoPoint(1, 2))).to.equal(
106-
'{"latitude":1,"longitude":2}'
107-
);
108-
expect(JSON.stringify(new GeoPoint(0, 0))).to.equal(
109-
'{"latitude":0,"longitude":0}'
110-
);
111-
expect(JSON.stringify(new GeoPoint(-0, -0))).to.equal(
112-
'{"latitude":0,"longitude":0}'
113-
);
114-
expect(JSON.stringify(new GeoPoint(90, 180))).to.equal(
115-
'{"latitude":90,"longitude":180}'
116-
);
105+
expect(new GeoPoint(1, 2).toJSON()).to.deep.equal({
106+
latitude: 1,
107+
longitude: 2
108+
});
109+
expect(new GeoPoint(0, 0).toJSON()).to.deep.equal({
110+
latitude: 0,
111+
longitude: 0
112+
});
113+
expect(new GeoPoint(-0, -0).toJSON()).to.deep.equal({
114+
latitude: 0,
115+
longitude: 0
116+
});
117+
expect(new GeoPoint(90, 180).toJSON()).to.deep.equal({
118+
latitude: 90,
119+
longitude: 180
120+
});
117121
});
118122
});

packages/firestore/test/unit/api/timestamp.test.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,17 @@ describe('Timestamp', () => {
134134
});
135135

136136
it('serializes to JSON', () => {
137-
expect(JSON.stringify(new Timestamp(123, 456))).to.equal(
138-
'{"seconds":123,"nanoseconds":456}'
139-
);
140-
expect(JSON.stringify(new Timestamp(0, 0))).to.equal(
141-
'{"seconds":0,"nanoseconds":0}'
142-
);
143-
expect(JSON.stringify(new Timestamp(-123, 456))).to.equal(
144-
'{"seconds":-123,"nanoseconds":456}'
145-
);
137+
expect(new Timestamp(123, 456).toJSON()).to.deep.equal({
138+
seconds: 123,
139+
nanoseconds: 456
140+
});
141+
expect(new Timestamp(0, 0).toJSON()).to.deep.equal({
142+
seconds: 0,
143+
nanoseconds: 0
144+
});
145+
expect(new Timestamp(-123, 456).toJSON()).to.deep.equal({
146+
seconds: -123,
147+
nanoseconds: 456
148+
});
146149
});
147150
});

0 commit comments

Comments
 (0)