taking a stab at fixing this

Author: Brian Chen

packages/firestore/exp/src/api/transaction.ts

@@ -29,7 +29,8 @@ import { Transaction as InternalTransaction } from '../../../src/core/transactio
 import { validateReference } from '../../../lite/src/api/write_batch';
 import { getDatastore } from '../../../lite/src/api/components';
 
-export class Transaction extends LiteTransaction
+export class Transaction
+  extends LiteTransaction
   implements firestore.Transaction {
   // This class implements the same logic as the Transaction API in the Lite SDK
   // but is subclassed in order to return its own DocumentSnapshot types.

packages/firestore/lite/src/api/field_value.ts

@@ -30,7 +30,8 @@ import { ParseContext } from '../../../src/api/user_data_reader';
 import { FieldTransform } from '../../../src/model/mutation';
 
 /** The public FieldValue class of the lite API. */
-export abstract class FieldValue extends SerializableFieldValue
+export abstract class FieldValue
+  extends SerializableFieldValue
   implements firestore.FieldValue {}
 
 /**

packages/firestore/src/api/database.ts

@@ -1101,17 +1101,23 @@ export class DocumentReference<T = DocumentData>
 
   set(value: Partial<T>, options: SetOptions): Promise<void>;
   set(value: T): Promise<void>;
-  set(value: T | Partial<T>, options?: SetOptions): Promise<void> {
-    validateBetweenNumberOfArgs('DocumentReference.set', arguments, 1, 2);
-    options = validateSetOptions('DocumentReference.set', options);
+  set(value: T, options?: SetOptions, parentFnName?: string): Promise<void>;
+  set(
+    value: T | Partial<T>,
+    options?: SetOptions,
+    parentFnName?: string
+  ): Promise<void> {
+    const methodName = parentFnName ? parentFnName : 'DocumentReference.set';
+    validateBetweenNumberOfArgs(methodName, arguments, 1, 3);
+    options = validateSetOptions(methodName, options);
     const convertedValue = applyFirestoreDataConverter(
       this._converter,
       value,
       options
     );
     const parsed = parseSetData(
       this.firestore._dataReader,
-      'DocumentReference.set',
+      methodName,
       this._key,
       convertedValue,
       this._converter !== null,
@@ -2375,12 +2381,10 @@ export class CollectionReference<T = DocumentData>
 
   add(value: T): Promise<PublicDocumentReference<T>> {
     validateExactNumberOfArgs('CollectionReference.add', arguments, 1);
-    const convertedValue = this._converter
-      ? this._converter.toFirestore(value)
-      : value;
-    validateArgType('CollectionReference.add', 'object', 1, convertedValue);
     const docRef = this.doc();
-    return docRef.set(value).then(() => docRef);
+    return ((docRef as unknown) as DocumentReference)
+      .set(value, undefined, 'CollectionReference.add')
+      .then(() => docRef);
   }
 
   withConverter<U>(

packages/firestore/test/integration/api/validation.test.ts

@@ -589,6 +589,18 @@ apiDescribe('Validation:', (persistence: boolean) => {
         });
     });
 
+    validationIt(
+      persistence,
+      'validates CollectionReference.add with correct function name',
+      db => {
+        const coll = db.collection('foo');
+
+        expect(() => coll.add(new TestClass('foo'))).to.throw(
+          'Function CollectionReference.add() called with invalid data.'
+        );
+      }
+    );
+
     validationIt(persistence, 'must not contain undefined.', db => {
       // Note: This test uses the default setting for `ignoreUndefinedProperties`.
       return expectWriteToFail(