some comment changes

Author: Brian Chen

.changeset/dirty-pandas-pay.md

@@ -3,7 +3,7 @@
 '@firebase/firestore': major
 ---
 
-This change contains multiple quality-of-life improvements when using the `FirestoreDataConverter` in `@firebase/firestore/lite` and `@firebase/firestore/exp`:
+This change contains multiple quality-of-life improvements when using the `FirestoreDataConverter` in `@firebase/firestore/lite` and `@firebase/firestore`:
 - Support for passing in `FieldValue` property values when using a converter (via `WithFieldValue<T>` and `PartialWithFieldValue<T>`).
 - Support for omitting properties in nested fields when performing a set operation with `{merge: true}` with a converter (via `PartialWithFieldValue<T>`).
 - [breaking] Support for typed update operations when using a converter (via the newly typed `UpdateData`). Improperly typed fields in

packages/firestore/src/lite/reference.ts

@@ -56,8 +56,6 @@ export interface DocumentData {
  */
 export type PartialWithFieldValue<T> = T extends Primitive
   ? T
-  : T extends Map<infer K, infer V>
-  ? Map<PartialWithFieldValue<K>, PartialWithFieldValue<V>>
   : T extends {}
   ? { [K in keyof T]?: PartialWithFieldValue<T[K]> | FieldValue }
   : Partial<T>;

packages/firestore/test/lite/integration.test.ts

@@ -1286,7 +1286,7 @@ describe('withConverter() support', () => {
 
       it('supports FieldValues', async () => {
         return withTestDoc(async doc => {
-          const ref = doc.withConverter(testConverter);
+          const ref = doc.withConverter(testConverterMerge);
 
           // Allow Field Values in nested partials.
           await setDoc(
@@ -1317,7 +1317,7 @@ describe('withConverter() support', () => {
 
       it('validates types in outer and inner fields', async () => {
         return withTestDoc(async doc => {
-          const ref = doc.withConverter(testConverter);
+          const ref = doc.withConverter(testConverterMerge);
 
           // Check top-level fields.
           await setDoc(
@@ -1359,7 +1359,7 @@ describe('withConverter() support', () => {
 
       it('checks for nonexistent properties', async () => {
         return withTestDoc(async doc => {
-          const ref = doc.withConverter(testConverter);
+          const ref = doc.withConverter(testConverterMerge);
           // Top-level property.
           await setDoc(
             ref,