Skip to content

Commit 745ef76

Browse files
committed
resolve comments
1 parent 8678c9f commit 745ef76

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

packages/firestore/src/core/firestore_client.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -512,11 +512,6 @@ export function firestoreClientRunAggregationQuery(
512512
client.asyncQueue.enqueueAndForget(async () => {
513513
const remoteStore = await getRemoteStore(client);
514514
if (!canUseNetwork(remoteStore)) {
515-
logDebug(
516-
LOG_TAG,
517-
'The network is disabled. The task returned by ' +
518-
"'getAggregateFromServerDirect()' will not complete until the network is enabled."
519-
);
520515
deferred.reject(
521516
new FirestoreError(
522517
Code.UNAVAILABLE,

packages/firestore/test/integration/api/aggregation.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@ apiDescribe('Aggregation query', (persistence: boolean) => {
4040
});
4141
});
4242

43-
it('getAggregateFromServerDirect fails if user is offline async', () => {
44-
const testDocs = {
45-
a: { author: 'authorA', title: 'titleA' }
46-
};
43+
it('getAggregateFromServerDirect fails if user is offline', () => {
44+
const testDocs = {};
4745
return withTestCollection(
4846
persistence,
4947
testDocs,

0 commit comments

Comments
 (0)