remove startMfaSignIn step for TOTP.

TOTP only needs a finalize step.

Author: prameshj

packages/auth/src/api/authentication/mfa.ts

@@ -51,27 +51,13 @@ export interface StartPhoneMfaSignInRequest {
   };
   tenantId?: string;
 }
-export interface StartTotpMfaSignInRequest {
-  mfaPendingCredential: string;
-  mfaEnrollmentId: string;
-  totpSignInInfo: {
-    verificationCode: string;
-  };
-  tenantId?: string;
-}
 
 export interface StartPhoneMfaSignInResponse {
   phoneResponseInfo: {
     sessionInfo: string;
   };
 }
 
-export interface StartTotpMfaSignInResponse {
-  totpSignInInfo: {
-    verificationCode: string;
-  };
-}
-
 export function startSignInPhoneMfa(
   auth: Auth,
   request: StartPhoneMfaSignInRequest
@@ -87,27 +73,15 @@ export function startSignInPhoneMfa(
   );
 }
 
-export function startSignInTotpMfa(
-  auth: Auth,
-  request: StartTotpMfaSignInRequest
-): Promise<StartTotpMfaSignInResponse> {
-  return _performApiRequest<
-    StartTotpMfaSignInRequest,
-    StartTotpMfaSignInResponse
-  >(
-    auth,
-    HttpMethod.POST,
-    Endpoint.START_MFA_SIGN_IN,
-    _addTidIfNecessary(auth, request)
-  );
-}
-
 export interface FinalizePhoneMfaSignInRequest {
   mfaPendingCredential: string;
   phoneVerificationInfo: SignInWithPhoneNumberRequest;
   tenantId?: string;
 }
 
+// TOTP MFA Sign in only has a finalize phase. Phone MFA has a start phase to initiate sending an
+// SMS and a finalize phase to complete sign in. With TOTP, the user already has the OTP in the
+// TOTP/Authenticator app.
 export interface FinalizeTotpMfaSignInRequest {
   mfaPendingCredential: string;
   totpVerificationInfo: { verificationCode: string };

packages/auth/src/mfa/mfa_info.ts

@@ -48,7 +48,6 @@ export abstract class MultiFactorInfoImpl implements MultiFactorInfo {
     if ('phoneInfo' in enrollment) {
       return PhoneMultiFactorInfoImpl._fromServerResponse(auth, enrollment);
     } else if ('totpInfo' in enrollment) {
-      // TODO(prameshj) ensure that this field is set by the backend once the tracking bug is fixed.
       return TotpMultiFactorInfoImpl._fromServerResponse(auth, enrollment);
     }
     return _fail(auth, AuthErrorCode.INTERNAL_ERROR);