Skip to content

Commit 76a62a6

Browse files
committed
Remove default expected input types
1 parent 2e83dca commit 76a62a6

File tree

2 files changed

+9
-21
lines changed

2 files changed

+9
-21
lines changed

packages/vertexai/src/methods/chrome-adapter.test.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,10 @@ describe('ChromeAdapter', () => {
124124
);
125125
const adapter = new ChromeAdapter(
126126
languageModelProvider,
127-
'prefer_on_device'
127+
'prefer_on_device',
128+
{
129+
expectedInputs: [{ type: 'image' }]
130+
}
128131
);
129132
const expectedOnDeviceParams = {
130133
expectedInputs: [{ type: 'image' }]
@@ -221,17 +224,14 @@ describe('ChromeAdapter', () => {
221224
);
222225
const promptOutput = 'hi';
223226
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
224-
const onDeviceParams = {
225-
systemPrompt: 'be yourself'
226-
} as LanguageModelCreateOptions;
227227
const expectedOnDeviceParams = {
228228
systemPrompt: 'be yourself',
229229
expectedInputs: [{ type: 'image' }]
230230
} as LanguageModelCreateOptions;
231231
const adapter = new ChromeAdapter(
232232
languageModelProvider,
233233
'prefer_on_device',
234-
onDeviceParams
234+
expectedOnDeviceParams
235235
);
236236
const request = {
237237
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
@@ -270,17 +270,14 @@ describe('ChromeAdapter', () => {
270270
);
271271
const promptOutput = 'hi';
272272
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
273-
const onDeviceParams = {
274-
systemPrompt: 'be yourself'
275-
} as LanguageModelCreateOptions;
276273
const expectedOnDeviceParams = {
277274
systemPrompt: 'be yourself',
278275
expectedInputs: [{ type: 'image' }]
279276
} as LanguageModelCreateOptions;
280277
const adapter = new ChromeAdapter(
281278
languageModelProvider,
282279
'prefer_on_device',
283-
onDeviceParams
280+
expectedOnDeviceParams
284281
);
285282
const request = {
286283
contents: [
@@ -379,14 +376,13 @@ describe('ChromeAdapter', () => {
379376
}
380377
})
381378
);
382-
const onDeviceParams = {} as LanguageModelCreateOptions;
383379
const expectedOnDeviceParams = {
384380
expectedInputs: [{ type: 'image' }]
385381
} as LanguageModelCreateOptions;
386382
const adapter = new ChromeAdapter(
387383
languageModelProvider,
388384
'prefer_on_device',
389-
onDeviceParams
385+
expectedOnDeviceParams
390386
);
391387
const request = {
392388
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
@@ -423,14 +419,13 @@ describe('ChromeAdapter', () => {
423419
}
424420
})
425421
);
426-
const onDeviceParams = {} as LanguageModelCreateOptions;
427422
const expectedOnDeviceParams = {
428423
expectedInputs: [{ type: 'image' }]
429424
} as LanguageModelCreateOptions;
430425
const adapter = new ChromeAdapter(
431426
languageModelProvider,
432427
'prefer_on_device',
433-
onDeviceParams
428+
expectedOnDeviceParams
434429
);
435430
const request = {
436431
contents: [

packages/vertexai/src/methods/chrome-adapter.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ export class ChromeAdapter {
4242
private languageModelProvider?: LanguageModel,
4343
private mode?: InferenceMode,
4444
private onDeviceParams: LanguageModelCreateOptions = {}
45-
) {
46-
this.addImageTypeAsExpectedInput();
47-
}
45+
) {}
4846

4947
/**
5048
* Checks if a given request can be made on-device.
@@ -237,11 +235,6 @@ export class ChromeAdapter {
237235
return newSession;
238236
}
239237

240-
private addImageTypeAsExpectedInput(): void {
241-
// Defaults to support image inputs for convenience.
242-
this.onDeviceParams.expectedInputs ??= [{ type: 'image' }];
243-
}
244-
245238
/**
246239
* Formats string returned by Chrome as a {@link Response} returned by Vertex.
247240
*/

0 commit comments

Comments
 (0)