fix tests

Author: Feiyang1

config/webpack.test.js

@@ -75,13 +75,13 @@ module.exports = {
           }
         }
       },
+      /**
+       * Transform firebase packages to cjs, so they can be stubbed in tests
+       */
       {
         test: /\.js$/,
         include: function (modulePath) {
           const match = /node_modules\/@firebase.*/.test(modulePath);
-          if (match) {
-            console.log('modulePath', modulePath, match);
-          }
           return match;
         },
         use: {

packages-exp/remote-config-exp/src/api.ts

@@ -103,13 +103,6 @@ export async function fetchConfig(remoteConfig: RemoteConfig): Promise<void> {
   }
 }
 
-export async function fetchAndActivate(
-  remoteConfig: RemoteConfig
-): Promise<boolean> {
-  await fetchConfig(remoteConfig);
-  return activate(remoteConfig);
-}
-
 export function getAll(remoteConfig: RemoteConfig): Record<string, ValueType> {
   const rc = asRemoteConfigImpl(remoteConfig);
   return getAllKeys(
@@ -157,7 +150,7 @@ export function getValue(remoteConfig: RemoteConfig, key: string): ValueType {
 export function setLogLevel(
   remoteConfig: RemoteConfig,
   logLevel: RemoteConfigLogLevel
-) {
+): void {
   const rc = asRemoteConfigImpl(remoteConfig);
   switch (logLevel) {
     case 'debug':

packages-exp/remote-config-exp/src/api2.ts

@@ -0,0 +1,28 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { RemoteConfig } from '@firebase/remote-config-types-exp';
+import { activate, fetchConfig } from './api';
+
+// This API is put in a separate file, so we can stub fetchConfig and activate in tests.
+// It's not possible to stub standalone functions from the same module.
+export async function fetchAndActivate(
+  remoteConfig: RemoteConfig
+): Promise<boolean> {
+  await fetchConfig(remoteConfig);
+  return activate(remoteConfig);
+}

packages-exp/remote-config-exp/src/index.ts

@@ -28,6 +28,7 @@ declare global {
 }
 
 export * from './api';
+export * from './api2';
 
 /** register component and version */
 registerRemoteConfig();

packages-exp/remote-config-exp/src/remote_config.ts

@@ -39,13 +39,13 @@ export class RemoteConfig implements RemoteConfigType {
    * Tracks completion of initialization promise.
    * @internal
    */
-  public _isInitializationComplete = false;
+  _isInitializationComplete = false;
 
   /**
    * De-duplicates initialization calls.
    * @internal
    */
-  public _initializePromise?: Promise<void>;
+  _initializePromise?: Promise<void>;
 
   settings: Settings = {
     fetchTimeoutMillis: DEFAULT_FETCH_TIMEOUT_MILLIS,