resolve todos

Author: Feiyang1

.github/workflows/update-api-reports.yml

@@ -21,7 +21,8 @@ jobs:
     - name: Yarn install
       run: yarn
     - name: Update API reports
-      run: yarn ts-node-script scripts/exp/update-api-reports.ts
+      # API reports are generated as part of the build
+      run: yarn build
       id: update-api-reports
     - name: Commit & Push changes
       uses: EndBug/add-and-commit@v7

package.json

@@ -22,7 +22,7 @@
   ],
   "scripts": {
     "dev": "lerna run --parallel --scope @firebase/* --scope firebase dev",
-    "build": "lerna run --scope @firebase/* --scope firebase --ignore @firebase/rules-unit-testing --ignore @firebase/firestore --ignore build",
+    "build": "lerna run --scope @firebase/* --scope firebase --ignore @firebase/rules-unit-testing --ignore @firebase/firestore build",
     "build:changed": "ts-node-script scripts/ci-test/build_changed.ts",
     "release:prepare": "lerna run --scope @firebase/* add-compat-overloads && lerna run --scope @firebase/* typings:public",
     "link:packages": "lerna exec --scope @firebase/* --scope firebase -- yarn link",

packages/performance-compat/src/index.ts

@@ -25,13 +25,6 @@ import { PerformanceCompatImpl } from './performance';
 import { name as packageName, version } from '../package.json';
 import { FirebasePerformance as FirebasePerformanceCompat } from '@firebase/performance-types';
 
-// TODO: move it to the future performance-compat-types package
-declare module '@firebase/component' {
-  interface NameServiceMapping {
-    'performance-compat': FirebasePerformanceCompat;
-  }
-}
-
 function registerPerformanceCompat(firebaseInstance: _FirebaseNamespace): void {
   firebaseInstance.INTERNAL.registerComponent(
     new Component(

packages/performance-types/index.d.ts

@@ -114,6 +114,6 @@ export interface PerformanceTrace {
 
 declare module '@firebase/component' {
   interface NameServiceMapping {
-    'performance': FirebasePerformance;
+    'performance-compat': FirebasePerformance;
   }
 }

packages/remote-config-compat/src/index.ts

@@ -26,13 +26,6 @@ import { RemoteConfigCompatImpl } from './remoteConfig';
 import { name as packageName, version } from '../package.json';
 import { RemoteConfig as RemoteConfigCompat } from '@firebase/remote-config-types';
 
-// TODO: move it to remote-config-types package
-declare module '@firebase/component' {
-  interface NameServiceMapping {
-    'remoteConfig-compat': RemoteConfigCompat;
-  }
-}
-
 function registerRemoteConfigCompat(
   firebaseInstance: _FirebaseNamespace
 ): void {