no firestore

Author: wu-hui

.github/workflows/test-changed-firestore.yml

@@ -38,7 +38,6 @@ jobs:
         run: |
           set -o pipefail
           yarn build:changed firestore | tee ${{ runner.temp }}/yarn.log.txt
-        continue-on-error: false
       - name: Check if Firestore is changed
         id: check-changed
         run: egrep "Skipping all" ${{ runner.temp }}/yarn.log.txt
@@ -50,12 +49,12 @@ jobs:
         id: set-output
         run: echo "CHANGED=true" >> "$GITHUB_OUTPUT";
       - name: Archive build
-        if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
+        if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
         run: |
           tar -cf build.tar --exclude=.git .
           gzip build.tar
       - name: Upload build archive
-        if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
+        if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
         uses: actions/upload-artifact@v3
         with:
           name: build.tar.gz

packages/firestore/src/api/database.ts

@@ -121,7 +121,7 @@ export class Firestore extends LiteFirestore {
       // usage throws an exception.
       configureFirestore(this);
     }
-    return null;
+    return this._firestoreClient!.terminate();
   }
 }