Make fixes to ListenerType

Author: hsubox76

packages/app-check/src/api.ts

@@ -165,7 +165,7 @@ export function onTokenChanged(
   addTokenListener(
     app,
     platformLoggerProvider,
-    ListenerType['3P'],
+    ListenerType.EXTERNAL,
     nextFn,
     errorFn
   );

packages/app-check/src/factory.ts

@@ -95,7 +95,7 @@ export function internalFactory(
       addTokenListener(
         app,
         platformLoggerProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       ),
     removeTokenListener: listener => removeTokenListener(app, listener)

packages/app-check/src/internal-api.test.ts

@@ -152,13 +152,13 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1
       );
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -183,13 +183,13 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1
       );
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -215,7 +215,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['3P'],
+        ListenerType.EXTERNAL,
         listener1,
         errorFn1
       );
@@ -238,14 +238,14 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener1,
         errorFn1
       );
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener2
       );
 
@@ -344,7 +344,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
 
@@ -361,7 +361,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
 
@@ -386,7 +386,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
       await clock.runAllAsync();
@@ -416,7 +416,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         fakeListener
       );
     });
@@ -435,7 +435,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
       expect(getState(app).tokenObservers.length).to.equal(1);
@@ -452,7 +452,7 @@ describe('internal api', () => {
       addTokenListener(
         app,
         fakePlatformLoggingProvider,
-        ListenerType['2P'],
+        ListenerType.INTERNAL,
         listener
       );
       expect(getState(app).tokenObservers.length).to.equal(1);

packages/app-check/src/internal-api.ts

@@ -307,7 +307,7 @@ function notifyTokenListeners(
 
   for (const observer of observers) {
     try {
-      if (observer.type === ListenerType['3P'] && token.error != null) {
+      if (observer.type === ListenerType.EXTERNAL && token.error != null) {
         // If this listener was added by a 3P call, send any token error to
         // the supplied error handler. A 3P observer always has an error
         // handler.

packages/app-check/src/state.ts

@@ -38,8 +38,8 @@ export interface AppCheckTokenObserver
 }
 
 export const enum ListenerType {
-  '2P' = '2P',
-  '3P' = '3P'
+  'INTERNAL' = 'INTERNAL',
+  'EXTERNAL' = 'EXTERNAL'
 }
 
 export interface AppCheckState {

packages/app-check/tsconfig.json

@@ -1,8 +1,7 @@
 {
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "preserveConstEnums": true
+    "outDir": "dist"
   },
   "exclude": [
     "dist/**/*"