throw if firebaseServerApp constructed in browser. Remove lib ESNext from app tsconfig

Author: DellaBitta

packages/app/src/api.ts

@@ -48,7 +48,7 @@ import {
   LogOptions,
   setUserLogHandler
 } from '@firebase/logger';
-import { deepEqual, getDefaultAppConfig } from '@firebase/util';
+import { deepEqual, getDefaultAppConfig, isBrowser } from '@firebase/util';
 
 export { FirebaseError } from '@firebase/util';
 
@@ -229,6 +229,11 @@ export function initializeServerApp(
   _options: FirebaseOptions | FirebaseApp,
   _serverAppConfig: FirebaseServerAppSettings
 ): FirebaseServerApp {
+  if (isBrowser()) {
+    // FirebaseServerApps aren't designed to be run in browsers.
+    throw ERROR_FACTORY.create(AppError.INVALID_SERVER_APP_ENVIRONMENT);
+  }
+
   const serverAppSettings: FirebaseServerAppSettings = {
     automaticDataCollectionEnabled: false,
     ..._serverAppConfig

packages/app/src/errors.ts

@@ -30,7 +30,8 @@ export const enum AppError {
   IDB_GET = 'idb-get',
   IDB_WRITE = 'idb-set',
   IDB_DELETE = 'idb-delete',
-  FINALIZATION_REGISTRY_NOT_SUPPORTED = 'finalization-registry-not-supported'
+  FINALIZATION_REGISTRY_NOT_SUPPORTED = 'finalization-registry-not-supported',
+  INVALID_SERVER_APP_ENVIRONMENT = 'invalid-server-app-environment'
 }
 
 const ERRORS: ErrorMap<AppError> = {
@@ -58,7 +59,9 @@ const ERRORS: ErrorMap<AppError> = {
   [AppError.IDB_DELETE]:
     'Error thrown when deleting from IndexedDB. Original error: {$originalErrorMessage}.',
   [AppError.FINALIZATION_REGISTRY_NOT_SUPPORTED]:
-    "FirebaseServerApp '{$appName}' deleteOnDeref field defined but the JS runtime does not support FinalizationRegistry."
+    'FirebaseServerApp deleteOnDeref field defined but the JS runtime does not support FinalizationRegistry.',
+  [AppError.INVALID_SERVER_APP_ENVIRONMENT]:
+    'FirebaseServerApp is not for use in browser environments.'
 };
 
 interface ErrorParams {

packages/app/tsconfig.json

@@ -2,8 +2,7 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "downlevelIteration": true,
-    "lib": ["ESNext"],
+    "downlevelIteration": true
   },
   "exclude": [
     "dist/**/*"