Skip to content

Commit 7db1889

Browse files
committed
PR feedback
1 parent f58a5d1 commit 7db1889

File tree

1 file changed

+5
-9
lines changed
  • packages-exp/auth-exp/src/platform_browser

1 file changed

+5
-9
lines changed

packages-exp/auth-exp/src/platform_browser/load_js.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,14 @@ function getScriptParentElement(): HTMLDocument | HTMLHeadElement {
2525
export function _loadJS(url: string): Promise<Event> {
2626
// TODO: consider adding timeout support & cancellation
2727
return new Promise((resolve, reject) => {
28-
function onError(e: Event | string): void {
29-
const errorEvent = e as ErrorEvent;
30-
const error =
31-
typeof errorEvent !== 'string' && errorEvent.error
32-
? errorEvent.error
33-
: _createError(AuthErrorCode.INTERNAL_ERROR);
34-
reject(error);
35-
}
3628
const el = document.createElement('script');
3729
el.setAttribute('src', url);
3830
el.onload = resolve;
39-
el.onerror = onError;
31+
el.onerror = e => {
32+
const error = _createError(AuthErrorCode.INTERNAL_ERROR);
33+
error.customData = e as unknown as Record<string, unknown>;
34+
reject(error);
35+
};
4036
el.type = 'text/javascript';
4137
el.charset = 'UTF-8';
4238
getScriptParentElement().appendChild(el);

0 commit comments

Comments
 (0)