PR feeback

Author: sam-gc

packages-exp/auth-compat-exp/src/auth.ts

@@ -82,8 +82,8 @@ export class Auth implements compat.FirebaseAuth, Wrapper<externs.Auth> {
   signOut(): Promise<void> {
     return this.auth.signOut();
   }
-  useEmulator(host: string): void {
-    this.auth.useEmulator(host);
+  useEmulator(url: string): void {
+    this.auth.useEmulator(url);
   }
   applyActionCode(code: string): Promise<void> {
     return impl.applyActionCode(this.auth, code);

packages-exp/auth-exp/src/api/index.test.ts

@@ -358,7 +358,7 @@ describe('api/_performApiRequest', () => {
 
     it('works properly with an emulated environment', () => {
       (auth.config as ConfigInternal).emulator = {
-        host: 'http://localhost:5000'
+        url: 'http://localhost:5000'
       };
       expect(_getFinalTarget(auth, 'host', '/path', 'query=test')).to.eq(
         'http://localhost:5000/host/path?query=test'

packages-exp/auth-exp/src/core/auth/auth_impl.ts

@@ -179,12 +179,12 @@ export class AuthImpl implements Auth, _FirebaseService {
     this.languageCode = _getUserLanguage();
   }
 
-  useEmulator(host: string): void {
+  useEmulator(url: string): void {
     assert(this._canInitEmulator, AuthErrorCode.EMULATOR_CONFIG_FAILED, {
       appName: this.name
     });
 
-    this.config.emulator = { host };
+    this.config.emulator = { url };
     this.settings.appVerificationDisabledForTesting = true;
   }
 

packages-exp/auth-exp/src/core/util/emulator.test.ts

@@ -23,12 +23,12 @@ import { _emulatorUrl } from './emulator';
 describe('core/util/emulator', () => {
   const config: ConfigInternal = {
     emulator: {
-      host: 'http://localhost:4000'
+      url: 'http://localhost:4000'
     }
   } as ConfigInternal;
 
   it('builds the proper URL with no path', () => {
-    expect(_emulatorUrl(config)).to.eq('http://localhost:4000');
+    expect(_emulatorUrl(config)).to.eq('http://localhost:4000/');
   });
 
   it('builds the proper URL with a path', () => {

packages-exp/auth-exp/src/core/util/emulator.ts

@@ -20,12 +20,12 @@ import { debugAssert } from './assert';
 
 export function _emulatorUrl(config: ConfigInternal, path?: string): string {
   debugAssert(config.emulator, 'Emulator should always be set here');
-  const { host: emulatorHost } = config.emulator;
+  const { url } = config.emulator;
+  const emulatorHost = new URL(url).toString();
 
   if (!path) {
     return emulatorHost;
   }
 
-  const sep = path.startsWith('/') ? '' : '/';
-  return `${emulatorHost}${sep}${path}`;
+  return `${emulatorHost}${path.startsWith('/') ? path.slice(1) : path}`;
 }

packages-exp/auth-exp/src/model/auth.ts

@@ -26,7 +26,7 @@ export type AuthDomain = string;
 
 export interface ConfigInternal extends externs.Config {
   emulator?: {
-    host: string;
+    url: string;
   };
 }
 

packages-exp/auth-types-exp/index.d.ts

@@ -137,7 +137,7 @@ export interface Auth {
   readonly currentUser: User | null;
   updateCurrentUser(user: User | null): Promise<void>;
   useDeviceLanguage(): void;
-  useEmulator(host: string): void;
+  useEmulator(url: string): void;
   signOut(): Promise<void>;
 }