Merge branch 'master' into mrschmidt/debug

Author: Feiyang1

.changeset/a-dark-knight.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+---
+
+Fixes a regression that prevented Firestore from detecting Auth during its initial initialization, which could cause some writes to not be send.
+[4971](https://github.com/firebase/firebase-js-sdk/pull/4971) didn't actually fix it.

.changeset/gentle-items-refuse.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
   },
   "devDependencies": {
-    "firebase": "8.6.4",
+    "firebase": "8.6.6",
     "@types/chai": "4.2.14",
     "@types/mocha": "7.0.2",
     "chai": "4.2.0",

integration/firebase/package.json

@@ -14,8 +14,8 @@
     "test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
   },
   "devDependencies": {
-    "@firebase/app": "0.6.23",
-    "@firebase/firestore": "2.3.3",
+    "@firebase/app": "0.6.25",
+    "@firebase/firestore": "2.3.5",
     "@types/mocha": "7.0.2",
     "gulp": "4.0.2",
     "gulp-filter": "6.0.0",

integration/firestore/package.json

@@ -9,9 +9,9 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "8.6.4",
+    "firebase": "8.6.6",
     "chai": "4.2.0",
-    "chromedriver": "89.0.0",
+    "chromedriver": "91.0.0",
     "express": "4.17.1",
     "geckodriver": "1.21.1",
     "mocha": "7.2.0",

integration/messaging/package.json

@@ -44,7 +44,7 @@
   },
   "typings": "dist/src/index.d.ts",
   "dependencies": {
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/analytics-exp": "0.0.900",
     "@firebase/analytics-types": "0.4.0",
     "@firebase/util": "1.1.0",

packages-exp/analytics-compat/package.json

@@ -35,7 +35,7 @@
     "@firebase/installations-exp": "0.0.900",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",

packages-exp/analytics-exp/package.json

@@ -31,7 +31,7 @@
     "@firebase/app-exp": "0.0.900",
     "@firebase/util": "1.1.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0",
     "dom-storage": "2.1.0",
     "xmlhttprequest": "1.8.0"

packages-exp/app-compat/package.json

@@ -32,7 +32,7 @@
   "dependencies": {
     "@firebase/util": "1.1.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",

packages-exp/app-exp/package.json

@@ -34,7 +34,7 @@
   "dependencies": {
     "@firebase/auth-exp": "0.0.900",
     "@firebase/auth-types": "0.10.3",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/util": "1.1.0",
     "node-fetch": "2.6.1",
     "selenium-webdriver": "^4.0.0-beta.2",

packages-exp/auth-compat-exp/package.json

@@ -51,7 +51,7 @@
     "@firebase/app-exp": "0.x"
   },
   "dependencies": {
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "1.1.0",
     "node-fetch": "2.6.1",

packages-exp/auth-exp/package.json

@@ -158,7 +158,7 @@ describe('api/authentication/finalizeSignInPhoneMfa', () => {
 
     await expect(finalizeSignInPhoneMfa(auth, request)).to.be.rejectedWith(
       FirebaseError,
-      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
+      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
     );
     expect(mock.calls[0].request).to.eql({
       tenantId: null,

packages-exp/auth-exp/src/api/authentication/mfa.test.ts

@@ -154,7 +154,7 @@ describe('api/authentication/signInWithPhoneNumber', () => {
 
     await expect(signInWithPhoneNumber(auth, request)).to.be.rejectedWith(
       FirebaseError,
-      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
+      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
     );
     expect(mock.calls[0].request).to.eql(request);
   });
@@ -222,7 +222,7 @@ describe('api/authentication/linkWithPhoneNumber', () => {
 
     await expect(linkWithPhoneNumber(auth, request)).to.be.rejectedWith(
       FirebaseError,
-      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user. (auth/invalid-verification-code).'
+      'Firebase: The SMS verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure to use the verification code provided by the user. (auth/invalid-verification-code).'
     );
     expect(mock.calls[0].request).to.eql(request);
   });

packages-exp/auth-exp/src/api/authentication/sms.test.ts

@@ -186,7 +186,7 @@ function _debugErrorMap(): ErrorMap<AuthErrorCode> {
     [AuthErrorCode.INVALID_AUTH_EVENT]: 'An internal AuthError has occurred.',
     [AuthErrorCode.INVALID_CODE]:
       'The SMS verification code used to create the phone auth credential is ' +
-      'invalid. Please resend the verification code sms and be sure use the ' +
+      'invalid. Please resend the verification code sms and be sure to use the ' +
       'verification code provided by the user.',
     [AuthErrorCode.INVALID_CONTINUE_URI]:
       'The continue URL provided in the request is invalid.',

packages-exp/auth-exp/src/core/errors.ts

@@ -1,6 +1,6 @@
 {
   "name": "firebase-exp",
-  "version": "9.0.0-beta.2",
+  "version": "9.0.0-beta.3",
   "private": true,
   "description": "Firebase JavaScript library for web and Node.js",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
@@ -56,6 +56,10 @@
       "node": "./messaging/dist/index.cjs.js",
       "default": "./messaging/dist/index.esm.js"
     },
+    "./messaging/sw": {
+      "node": "./messaging/sw/dist/index.cjs.js",
+      "default": "./messaging/sw/dist/index.esm.js"
+    },
     "./performance": {
       "node": "./performance/dist/index.cjs.js",
       "default": "./performance/dist/index.esm.js"
@@ -129,11 +133,11 @@
     "@firebase/app-compat": "0.0.900",
     "@firebase/auth-exp": "0.0.900",
     "@firebase/auth-compat": "0.0.900",
-    "@firebase/database": "0.10.3",
+    "@firebase/database": "0.10.4",
     "@firebase/functions-exp": "0.0.900",
     "@firebase/functions-compat": "0.0.900",
-    "@firebase/firestore": "2.3.3",
-    "@firebase/storage": "0.5.3",
+    "@firebase/firestore": "2.3.5",
+    "@firebase/storage": "0.5.4",
     "@firebase/performance-exp": "0.0.900",
     "@firebase/performance-compat": "0.0.900",
     "@firebase/remote-config-exp": "0.0.900",

packages-exp/firebase-exp/package.json

@@ -47,7 +47,7 @@
   },
   "typings": "dist/src/index.d.ts",
   "dependencies": {
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/functions-exp": "0.0.900",
     "@firebase/functions-types": "0.4.0",
     "@firebase/messaging-types": "0.5.0",

packages-exp/functions-compat/package.json

@@ -50,7 +50,7 @@
   },
   "typings": "dist/functions-exp-public.d.ts",
   "dependencies": {
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/messaging-types": "0.5.0",
     "@firebase/util": "1.1.0",
     "node-fetch": "2.6.1",

packages-exp/functions-exp/package.json

@@ -52,7 +52,7 @@
     "@firebase/installations-exp": "0.0.900",
     "@firebase/installations-types": "0.3.4",
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "idb": "3.0.2",
     "tslib": "^2.1.0"
   },

packages-exp/installations-compat/package.json

@@ -56,7 +56,7 @@
   },
   "dependencies": {
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "idb": "3.0.2",
     "tslib": "^2.1.0"
   },

packages-exp/installations-exp/package.json

@@ -25,14 +25,14 @@
     "test:karma": "karma start --single-run",
     "test:debug": "karma start --browsers=Chrome --auto-watch",
     "type-check": "tsc --noEmit",
-    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/messaging-exp-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
+    "add-compat-overloads": "ts-node-script ../../scripts/exp/create-overloads.ts -i ../messaging-exp/dist/index-public.d.ts -o dist/src/index.d.ts -a -r FirebaseMessaging:MessagingCompat -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/messaging"
   },
   "peerDependencies": {
     "@firebase/app-compat": "0.x"
   },
   "dependencies": {
     "@firebase/messaging-exp": "0.0.900",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/installations-exp": "0.0.900",
     "@firebase/util": "1.1.0",
     "tslib": "^2.1.0"

packages-exp/messaging-compat/package.json

@@ -8,8 +8,15 @@
   }],
   "dtsRollup": {
     /** 
-     * rollup is not supported when multiple entry points are present
+     * rollup is not supported when multiple entry points are present.
+     * npm script api-report:rollup is used to generate dts rollup.
      */
     "enabled": false
-  }
+  },
+  "apiReport": {
+    /**
+     * apiReport is handled by npm script api-report:rollup
+     */
+    "enabled": false
+}
 }

packages-exp/messaging-exp/api-extractor.json

@@ -18,22 +18,25 @@
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "build": "rollup -c && yarn api-report",
     "build:deps": "lerna run --scope @firebase/'{app-exp,messaging-exp}' --include-dependencies build",
-    "build:release": "rollup -c rollup.config.release.js && yarn api-report",
+    "build:release": "rollup -c rollup.config.release.js && yarn api-report && yarn typings:public",
     "dev": "rollup -c -w",
     "test": "run-p test:karma type-check lint ",
     "test:integration": "run-p test:karma type-check lint && cd ../../integration/messaging && npm run-script test",
     "test:ci": "node ../../scripts/run_tests_in_ci.js",
     "test:karma": "karma start --single-run",
     "test:debug": "karma start --browsers=Chrome --auto-watch",
-    "api-report": "api-extractor run --local --verbose",
-    "type-check": "tsc --noEmit"
+    "api-report": "yarn api-report:rollup && yarn api-report:api-json",
+    "api-report:rollup": "ts-node-script ../../repo-scripts/prune-dts/extract-public-api.ts --package messaging-exp --packageRoot . --typescriptDts ./dist/index.d.ts --rollupDts ./dist/private.d.ts --untrimmedRollupDts ./dist/internal.d.ts --publicDts ./dist/index-public.d.ts",
+    "api-report:api-json": "api-extractor run --local --verbose",
+    "type-check": "tsc --noEmit",
+    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/index-public.d.ts"
   },
   "license": "Apache-2.0",
   "peerDependencies": {
     "@firebase/app-exp": "0.x"
   },
   "dependencies": {
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "@firebase/installations-exp": "0.0.900",
     "@firebase/util": "1.1.0",
     "idb": "3.0.2",
@@ -54,4 +57,4 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "esm5": "dist/index.esm.js"
-}
+}

packages-exp/messaging-exp/package.json

@@ -27,7 +27,6 @@ import { extractAppConfig } from './helpers/extract-app-config';
 export class MessagingService implements _FirebaseService {
   readonly app!: FirebaseApp;
   readonly firebaseDependencies!: FirebaseInternalDependencies;
-  deleteService!: () => Promise<void>;
 
   swRegistration?: ServiceWorkerRegistration;
   vapidKey?: string;
@@ -58,6 +57,6 @@ export class MessagingService implements _FirebaseService {
   }
 
   _delete(): Promise<void> {
-    return this.deleteService();
+    return Promise.resolve();
   }
 }

packages-exp/messaging-exp/src/messaging-service.ts

@@ -34,7 +34,7 @@
     "@firebase/performance-types": "0.0.13",
     "@firebase/util": "1.1.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "devDependencies": {

packages-exp/performance-compat/package.json

@@ -34,7 +34,7 @@
     "@firebase/logger": "0.2.6",
     "@firebase/installations-exp": "0.0.900",
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",

packages-exp/performance-exp/package.json

@@ -33,7 +33,7 @@
     "@firebase/remote-config-types": "0.1.9",
     "@firebase/util": "1.1.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "devDependencies": {

packages-exp/remote-config-compat/package.json

@@ -36,7 +36,7 @@
     "@firebase/installations-exp": "0.0.900",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",

packages-exp/remote-config-exp/package.json

@@ -1,5 +1,13 @@
 # @firebase/analytics
 
+## 0.6.12
+
+### Patch Changes
+
+- Updated dependencies [[`4c4b6aed9`](https://github.com/firebase/firebase-js-sdk/commit/4c4b6aed9757c9a7e75fb698a15e53274f93880b)]:
+  - @firebase/component@0.5.2
+  - @firebase/installations@0.4.28
+
 ## 0.6.11
 
 ### Patch Changes

packages/analytics/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/analytics",
-  "version": "0.6.11",
+  "version": "0.6.12",
   "description": "A analytics package for new firebase packages",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.cjs.js",
@@ -27,15 +27,15 @@
   },
   "dependencies": {
     "@firebase/analytics-types": "0.4.0",
-    "@firebase/installations": "0.4.27",
+    "@firebase/installations": "0.4.28",
     "@firebase/logger": "0.2.6",
     "@firebase/util": "1.1.0",
-    "@firebase/component": "0.5.1",
+    "@firebase/component": "0.5.2",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",
   "devDependencies": {
-    "@firebase/app": "0.6.23",
+    "@firebase/app": "0.6.25",
     "rollup": "2.35.1",
     "@rollup/plugin-commonjs": "17.1.0",
     "@rollup/plugin-json": "4.1.0",

packages/analytics/package.json

@@ -1,5 +1,12 @@
 # @firebase/app-check
 
+## 0.1.3
+
+### Patch Changes
+
+- Updated dependencies [[`4c4b6aed9`](https://github.com/firebase/firebase-js-sdk/commit/4c4b6aed9757c9a7e75fb698a15e53274f93880b)]:
+  - @firebase/component@0.5.2
+
 ## 0.1.2
 
 ### Patch Changes