Skip to content

Commit 8758d33

Browse files
committed
Use eslint-disable-next-line instead of eslint-ignore
1 parent d056f94 commit 8758d33

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/analytics/src/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ async function gtagOnEvent(
185185
// if not all entries in the 'send_to' field could be mapped to
186186
// a FID. In these cases, wait on all pending initialization promises.
187187
if (initializationPromisesToWaitFor.length === 0) {
188-
/* eslint-disable @typescript-eslint/no-floating-promises */
188+
/* eslint-disable-next-line @typescript-eslint/no-floating-promises */
189189
initializationPromisesToWaitFor = Object.values(
190190
initializationPromisesMap
191191
);

packages/auth-compat/test/helpers/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import * as sinon from 'sinon';
1919
import firebase from '@firebase/app-compat';
20-
/* eslint-disable import/no-extraneous-dependencies */
20+
/* eslint-disable-next-line import/no-extraneous-dependencies */
2121
import '@firebase/auth-compat';
2222
import { Provider } from '@firebase/component';
2323
import '../..';

packages/firestore/src/util/async_queue_impl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ export class AsyncQueueImpl implements AsyncQueue {
286286
// Note that draining may generate more delayed ops, so we do that first.
287287
return this.drain().then(() => {
288288
// Run ops in the same order they'd run if they ran naturally.
289-
/* eslint-disable @typescript-eslint/no-floating-promises */
289+
/* eslint-disable-next-line @typescript-eslint/no-floating-promises */
290290
this.delayedOperations.sort((a, b) => a.targetTimeMs - b.targetTimeMs);
291291

292292
for (const op of this.delayedOperations) {
@@ -311,8 +311,8 @@ export class AsyncQueueImpl implements AsyncQueue {
311311
private removeDelayedOperation(op: DelayedOperation<unknown>): void {
312312
// NOTE: indexOf / slice are O(n), but delayedOperations is expected to be small.
313313
const index = this.delayedOperations.indexOf(op);
314-
/* eslint-disable @typescript-eslint/no-floating-promises */
315314
debugAssert(index >= 0, 'Delayed operation not found.');
315+
/* eslint-disable-next-line @typescript-eslint/no-floating-promises */
316316
this.delayedOperations.splice(index, 1);
317317
}
318318
}

0 commit comments

Comments
 (0)