Make the api conform to specifications

Author: sam-gc

packages-exp/auth-compat-exp/src/auth.ts

@@ -97,8 +97,8 @@ export class Auth
   signOut(): Promise<void> {
     return this.auth.signOut();
   }
-  useEmulator(url: string, disableBanner = false): void {
-    this.auth.useEmulator(url, disableBanner);
+  useEmulator(url: string, options?: {disableWarnings: boolean}): void {
+    this.auth.useEmulator(url, options);
   }
   applyActionCode(code: string): Promise<void> {
     return impl.applyActionCode(this.auth, code);

packages-exp/auth-exp/src/core/auth/auth_impl.test.ts

@@ -554,7 +554,7 @@ describe('core/auth/auth_impl useEmulator', () => {
 
     it('logs out the warning but has no banner if disableBanner true', () => {
       sinon.stub(console, 'info');
-      auth.useEmulator('http://localhost:2020', true);
+      auth.useEmulator('http://localhost:2020', {disableWarnings: true});
       expect(console.info).to.have.been.calledWith(
         'WARNING: You are using the Auth Emulator,' +
           ' which is intended for local testing only.  Do not use with' +

packages-exp/auth-exp/src/core/auth/auth_impl.ts

@@ -271,7 +271,7 @@ export class AuthImpl implements Auth, _FirebaseService {
     this.languageCode = _getUserLanguage();
   }
 
-  useEmulator(url: string, disableBanner = false): void {
+  useEmulator(url: string, options?: {disableWarnings: boolean}): void {
     _assert(this._canInitEmulator, this, AuthErrorCode.EMULATOR_CONFIG_FAILED);
 
     _assert(
@@ -282,7 +282,7 @@ export class AuthImpl implements Auth, _FirebaseService {
 
     this.config.emulator = { url };
     this.settings.appVerificationDisabledForTesting = true;
-    emitEmulatorWarning(disableBanner);
+    emitEmulatorWarning(!!options?.disableWarnings);
   }
 
   async _delete(): Promise<void> {
@@ -592,8 +592,8 @@ function emitEmulatorWarning(disableBanner: boolean): void {
   if (typeof console !== 'undefined' && typeof console.info === 'function') {
     console.info(
       'WARNING: You are using the Auth Emulator,' +
-        ' which is intended for local testing only.  Do not use with' +
-        ' production credentials.'
+          ' which is intended for local testing only.  Do not use with' +
+          ' production credentials.'
     );
   }
   if (

packages-exp/auth-types-exp/index.d.ts

@@ -318,7 +318,7 @@ export interface Auth {
    * @param url - The URL at which the emulator is running (eg, 'http://localhost:9099').
    * @param disableBanner - (Optional: default false) Disable the warning banner attached to the DOM
    */
-  useEmulator(url: string, disableBanner?: boolean): void;
+  useEmulator(url: string, options?: {disableWarnings: boolean}): void;
   /**
    * Signs out the current user.
    */