Standardize replace plugin usage

Author: mmermerkaya

packages/app/declarations.d.ts

@@ -0,0 +1,19 @@
+/**
+ * @license
+ * Copyright 2019 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** Will be replaced by Rollup */
+declare const __JSCORE_VERSION__: string;

packages/app/rollup.config.js

@@ -34,9 +34,9 @@ const es5BuildPlugins = [
     typescript
   }),
   replace({
-    delimiters: ['${', '}'],
+    delimiters: ['__', '__'],
     values: {
-      JSCORE_VERSION: firebasePkg.version
+      JSCORE_VERSION: JSON.stringify(firebasePkg.version)
     }
   })
 ];
@@ -99,9 +99,9 @@ const es2017BuildPlugins = [
     }
   }),
   replace({
-    delimiters: ['${', '}'],
+    delimiters: ['__', '__'],
     values: {
-      JSCORE_VERSION: firebasePkg.version
+      JSCORE_VERSION: JSON.stringify(firebasePkg.version)
     }
   })
 ];

packages/app/src/firebaseNamespaceCore.ts

@@ -62,7 +62,7 @@ export function createFirebaseNamespaceCore(
     initializeApp: initializeApp,
     app: app as any,
     apps: null as any,
-    SDK_VERSION: '${JSCORE_VERSION}',
+    SDK_VERSION: __JSCORE_VERSION__,
     INTERNAL: {
       registerService,
       removeApp,

packages/app/src/lite/firebaseNamespaceLite.ts

@@ -28,7 +28,7 @@ import { createFirebaseNamespaceCore } from '../firebaseNamespaceCore';
 export function createFirebaseNamespaceLite(): FirebaseNamespace {
   const namespace = createFirebaseNamespaceCore(FirebaseAppLiteImpl);
 
-  namespace.SDK_VERSION = '${JSCORE_VERSION}_LITE';
+  namespace.SDK_VERSION = `${__JSCORE_VERSION__}_LITE`;
 
   const registerService = (namespace as _FirebaseNamespace).INTERNAL
     .registerService;

packages/installations/rollup.config.js

@@ -28,7 +28,10 @@ const deps = Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies });
 const es5BuildPlugins = [
   typescriptPlugin({ typescript }),
   replace({
-    __VERSION__: pkg.version
+    delimiters: ['__', '__'],
+    values: {
+      VERSION: JSON.stringify(pkg.version)
+    }
   })
 ];
 
@@ -57,7 +60,10 @@ const es2017BuildPlugins = [
     }
   }),
   replace({
-    __VERSION__: pkg.version
+    delimiters: ['__', '__'],
+    values: {
+      VERSION: JSON.stringify(pkg.version)
+    }
   })
 ];
 

packages/installations/src/declarations.d.ts

@@ -0,0 +1,19 @@
+/**
+ * @license
+ * Copyright 2019 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** Will be replaced by Rollup */
+declare const __VERSION__: string;

packages/installations/src/util/constants.ts

@@ -17,7 +17,7 @@
 
 export const PENDING_TIMEOUT_MS = 10000;
 
-export const PACKAGE_VERSION = 'w:__VERSION__'; // Will be replaced by Rollup
+export const PACKAGE_VERSION = `w:${__VERSION__}`;
 export const INTERNAL_AUTH_VERSION = 'FIS_v2';
 
 export const INSTALLATIONS_API_URL =

packages/installations/test-app/rollup.config.js

@@ -41,7 +41,10 @@ export default [
         tsconfigOverride: { compilerOptions: { declaration: false } }
       }),
       replace({
-        __VERSION__: pkg.version
+        delimiters: ['__', '__'],
+        values: {
+          VERSION: pkg.version
+        }
       }),
       resolve(),
       commonjs(),

packages/performance/declarations.d.ts

@@ -0,0 +1,19 @@
+/**
+ * @license
+ * Copyright 2019 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** Will be replaced by Rollup */
+declare const __PERF_SDK_VERSION__: string;

packages/performance/rollup.config.js

@@ -31,9 +31,9 @@ const es5BuildPlugins = [
     typescript
   }),
   replace({
-    delimiters: ['<', '>'],
+    delimiters: ['__', '__'],
     values: {
-      PERF_SDK_VERSION: pkg.version
+      PERF_SDK_VERSION: JSON.stringify(pkg.version)
     }
   })
 ];
@@ -64,9 +64,9 @@ const es2017BuildPlugins = [
     }
   }),
   replace({
-    delimiters: ['<', '>'],
+    delimiters: ['__', '__'],
     values: {
-      PERF_SDK_VERSION: pkg.version
+      PERF_SDK_VERSION: JSON.stringify(pkg.version)
     }
   })
 ];

packages/performance/src/constants.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-export const SDK_VERSION = '<PERF_SDK_VERSION>';
+export const SDK_VERSION = __PERF_SDK_VERSION__;
 /** The prefix for start User Timing marks used for creating Traces. */
 export const TRACE_START_MARK_PREFIX = 'FB-PERF-TRACE-START';
 /** The prefix for stop User Timing marks used for creating Traces. */

packages/performance/src/services/perf_logger.test.ts

@@ -83,7 +83,7 @@ describe('Performance Monitoring > perf_logger', () => {
       const START_TIME = 12345;
       const DURATION = 321;
       const EXPECTED_TRACE_MESSAGE = `{"application_info":{"google_app_id":"${APP_ID}",\
-"app_instance_id":"${IID}","web_app_info":{"sdk_version":"<PERF_SDK_VERSION>",\
+"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${__PERF_SDK_VERSION__}",\
 "page_url":"${PAGE_URL}","service_worker_status":${SERVICE_WORKER_STATUS},\
 "visibility_state":${VISIBILITY_STATE},"effective_connection_type":${EFFECTIVE_CONNECTION_TYPE}},\
 "application_process_state":0},"trace_metric":{"name":"${TRACE_NAME}","is_auto":false,\
@@ -137,7 +137,7 @@ describe('Performance Monitoring > perf_logger', () => {
           1000
       );
       const EXPECTED_NETWORK_MESSAGE = `{"application_info":{"google_app_id":"${APP_ID}",\
-"app_instance_id":"${IID}","web_app_info":{"sdk_version":"<PERF_SDK_VERSION>",\
+"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${__PERF_SDK_VERSION__}",\
 "page_url":"${PAGE_URL}","service_worker_status":${SERVICE_WORKER_STATUS},\
 "visibility_state":${VISIBILITY_STATE},"effective_connection_type":${EFFECTIVE_CONNECTION_TYPE}},\
 "application_process_state":0},\