PR feedback

Author: inlined

.changeset/new-bugs-think.md

@@ -1,7 +1,6 @@
 ---
 "@firebase/functions-compat": patch
 "@firebase/functions": patch
-"firebase-size-analysis": patch
 ---
 
 Add httpsCallableFromURL

e2e/sample-apps/modular.js

@@ -118,8 +118,8 @@ async function authLogout(app) {
  */
 async function callFunctions(app) {
   console.log('[FUNCTIONS] start');
-  let functions = getFunctions(app);
-  let callTest = httpsCallable(functions, 'callTest');
+  const functions = getFunctions(app);
+  const callTest = httpsCallable(functions, 'callTest');
   try {
     const result = await callTest({ data: 'blah' });
     console.log('[FUNCTIONS] result (by name):', result.data);

packages/functions/src/api.ts

@@ -93,7 +93,7 @@ export function httpsCallable<RequestData = unknown, ResponseData = unknown>(
 }
 
 /**
- * Returns a reference to the callable HTTPS trigger with the given name.
+ * Returns a reference to the callable HTTPS trigger with the specified url.
  * @param url - The url of the trigger.
  * @public
  */

repo-scripts/size-analysis/bundle-definitions/functions.json

@@ -22,8 +22,7 @@
             "path": "functions",
             "imports": [
               "getFunctions",
-              "httpsCallable",
-              "httpsCallableFromURL"
+              "httpsCallable"
             ]
           }
         ]