Merge branch 'master' into fei-typename-database

Author: Feiyang1

.changeset/curly-shrimps-wait.md

@@ -0,0 +1,6 @@
+---
+'@firebase/storage': minor
+'firebase': minor
+---
+
+Add NodeJS support to Cloud Storage for Firebase. This release changes the `main` field in package.json to point to a Node specific build. If you are building a bundle for borwser usage, please make sure that your bundler uses the `browser` field (the default).

.changeset/nasty-hats-hope.md

@@ -0,0 +1,6 @@
+---
+'@firebase/analytics-types': minor
+'firebase': minor
+---
+
+Add `firebase_screen` and `firebase_screen_class` to `logEvent()` overload for `screen_view` events.

.changeset/nine-needles-compare.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+The SDK no longer accesses IndexedDB during a page unload event on Safari 14. This aims to reduce the occurrence of an IndexedDB bug in Safari (https://bugs.webkit.org/show_bug.cgi?id=226547).

.changeset/silent-seals-approve.md

@@ -0,0 +1,6 @@
+---
+"firebase": patch
+"@firebase/firestore": patch
+---
+
+Fixed an issue that prevented Timestamps from being used via `update()` when connected to the Emulator

.changeset/thirty-suits-switch.md

@@ -0,0 +1,5 @@
+---
+'@firebase/database': patch
+---
+
+Fix sending of auth tokens on node.

.changeset/wet-pets-travel.md

@@ -15,8 +15,6 @@
 #
 #   - @Feiyang1
 #   - @hiranya911
-#   - @bojeil-google
-#   - @depoll
 #   - @hsubox76
 
 
@@ -90,13 +88,13 @@ packages-exp/auth-exp  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-appro
 packages-exp/auth-compat-exp @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
 
 # Installations-Exp Code
-packages/installations-exp @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
-packages/installations-types-exp @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
+packages/installations-exp @avolkovi @yoyomyo @firebase/jssdk-global-approvers
+packages/installations-types-exp @avolkovi @yoyomyo @firebase/jssdk-global-approvers
 
 # Perf-Exp Code
 packages/performance-exp  @alikn @zijianjoy @firebase/jssdk-global-approvers
 packages/performance-types-exp  @alikn @zijianjoy @firebase/jssdk-global-approvers
 
 # RC-Exp Code
 packages/remote-config-exp  @erikeldridge @firebase/jssdk-global-approvers
-packages/remote-config-compat  @erikeldridge @firebase/jssdk-global-approvers
+packages/remote-config-compat  @erikeldridge @firebase/jssdk-global-approvers

.github/CODEOWNERS

@@ -33,4 +33,4 @@ jobs:
       if: ${{steps.check-doc-changes.outputs.DOC_CHANGED == 'true'}}
       with:
         labels: doc-changes
-        github_token: ${{ secrets.GITHUB_TOKEN }}
+        github_token: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}

.github/workflows/label-doc-changes.yml

@@ -143,7 +143,7 @@ an individual package directory.
 The Firebase JS SDK is built with a series of individual packages that are all
 contained in this repository. Development is coordinated via [yarn
 workspaces](https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/) and
-[Lerna](https://lernajs.io/) (a monorepo management tool).
+[Lerna](https://lerna.js.org/) (a monorepo management tool).
 
 Each package in the `packages` directory, constitute a piece of our
 implementation. The SDK is built via a combination of all of these packages

README.md

@@ -74,6 +74,8 @@ export interface EventParams {
     event_label?: string;
     // (undocumented)
     fatal?: boolean;
+    firebase_screen?: string;
+    firebase_screen_class?: string;
     // (undocumented)
     item_list_id?: string;
     // (undocumented)
@@ -295,6 +297,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | '
 export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams?: {
     app_name: string;
     screen_name: EventParams['screen_name'];
+    firebase_screen: EventParams['firebase_screen'];
+    firebase_screen_class: EventParams['firebase_screen_class'];
     app_id?: string;
     app_version?: string;
     app_installer_id?: string;

common/api-review/analytics-exp.api.md

@@ -173,6 +173,11 @@ export interface ConfirmationResult {
 // @public
 export function confirmPasswordReset(auth: Auth, oobCode: string, newPassword: string): Promise<void>;
 
+// @public
+export function connectAuthEmulator(auth: Auth, url: string, options?: {
+    disableWarnings: boolean;
+}): void;
+
 // @public
 export function createUserWithEmailAndPassword(auth: Auth, email: string, password: string): Promise<UserCredential>;
 
@@ -644,11 +649,6 @@ export function updateProfile(user: User, { displayName, photoURL: photoUrl }: {
     photoURL?: string | null;
 }): Promise<void>;
 
-// @public
-export function useAuthEmulator(auth: Auth, url: string, options?: {
-    disableWarnings: boolean;
-}): void;
-
 // @public
 export function useDeviceLanguage(auth: Auth): void;
 

common/api-review/auth-exp.api.md

@@ -23,6 +23,11 @@ export interface DatabaseReference extends Query {
     readonly root: DatabaseReference;
 }
 
+// @public
+export function connectDatabaseEmulator(db: FirebaseDatabase, host: string, port: number, options?: {
+    mockUserToken?: EmulatorMockTokenOptions;
+}): void;
+
 // @public
 export class DataSnapshot {
     child(path: string): DataSnapshot;
@@ -229,10 +234,5 @@ export type Unsubscribe = () => void;
 // @public
 export function update(ref: DatabaseReference, values: object): Promise<void>;
 
-// @public
-export function useDatabaseEmulator(db: Database, host: string, port: number, options?: {
-    mockUserToken?: EmulatorMockTokenOptions;
-}): void;
-
 
 ```

common/api-review/database.api.md

@@ -7,6 +7,9 @@
 import { FirebaseApp } from '@firebase/app-exp';
 import { FirebaseError } from '@firebase/util';
 
+// @public
+export function connectFunctionsEmulator(functionsInstance: Functions, host: string, port: number): void;
+
 // @public
 export interface Functions {
     app: FirebaseApp;
@@ -42,8 +45,5 @@ export interface HttpsCallableResult<ResponseData = unknown> {
     readonly data: ResponseData;
 }
 
-// @public
-export function useFunctionsEmulator(functionsInstance: Functions, host: string, port: number): void;
-
 
 ```

common/api-review/functions-exp.api.md

@@ -15,6 +15,9 @@ import { Provider } from '@firebase/component';
 import { Subscribe } from '@firebase/util';
 import { Unsubscribe } from '@firebase/util';
 
+// @public
+export function connectStorageEmulator(storage: StorageService, host: string, port: number): void;
+
 // @public
 export function deleteObject(ref: StorageReference): Promise<void>;
 
@@ -254,8 +257,5 @@ export interface UploadTaskSnapshot {
     totalBytes: number;
 }
 
-// @public
-export function useStorageEmulator(storage: StorageService, host: string, port: number): void;
-
 
 ```

common/api-review/storage.api.md

@@ -7,11 +7,11 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
   },
   "devDependencies": {
-    "firebase": "8.7.0",
+    "firebase": "8.7.1",
     "@types/chai": "4.2.14",
-    "@types/mocha": "7.0.2",
+    "@types/mocha": "8.2.3",
     "chai": "4.3.4",
-    "karma": "5.2.3",
+    "karma": "6.3.4",
     "karma-babel-preprocessor": "8.0.1",
     "karma-chrome-launcher": "3.1.0",
     "karma-firefox-launcher": "2.1.0",

integration/firebase/package.json

@@ -16,11 +16,11 @@
   "devDependencies": {
     "@firebase/app": "0.6.28",
     "@firebase/firestore": "2.3.8",
-    "@types/mocha": "7.0.2",
+    "@types/mocha": "8.2.3",
     "gulp": "4.0.2",
-    "gulp-filter": "6.0.0",
+    "gulp-filter": "7.0.0",
     "gulp-replace": "1.1.3",
-    "karma": "5.2.3",
+    "karma": "6.3.4",
     "karma-chrome-launcher": "3.1.0",
     "karma-firefox-launcher": "2.1.0",
     "karma-mocha": "2.0.1",

integration/firestore/package.json

@@ -9,7 +9,7 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "8.7.0",
+    "firebase": "8.7.1",
     "chai": "4.3.4",
     "chromedriver": "91.0.0",
     "express": "4.17.1",

integration/messaging/package.json

@@ -80,7 +80,7 @@
     "@types/inquirer": "7.3.1",
     "@types/listr": "0.14.2",
     "@types/long": "4.0.1",
-    "@types/mocha": "7.0.2",
+    "@types/mocha": "8.2.3",
     "@types/mz": "2.7.3",
     "@types/node": "12.20.15",
     "@types/sinon": "9.0.10",
@@ -117,10 +117,10 @@
     "inquirer": "8.1.1",
     "istanbul-instrumenter-loader": "3.0.1",
     "js-yaml": "4.1.0",
-    "karma": "5.2.3",
+    "karma": "6.3.4",
     "karma-chrome-launcher": "3.1.0",
     "karma-cli": "2.0.0",
-    "karma-coverage-istanbul-reporter": "2.1.1",
+    "karma-coverage-istanbul-reporter": "3.0.3",
     "karma-firefox-launcher": "2.1.0",
     "karma-mocha": "2.0.1",
     "karma-mocha-reporter": "2.2.5",
@@ -130,7 +130,7 @@
     "karma-summary-reporter": "2.0.0",
     "karma-webpack": "4.0.2",
     "lcov-result-merger": "3.1.0",
-    "lerna": "3.22.1",
+    "lerna": "4.0.0",
     "listr": "0.14.3",
     "lodash": "4.17.20",
     "long": "3.2.0",

package.json

@@ -450,6 +450,8 @@ export function logEvent(
   eventParams?: {
     app_name: string;
     screen_name: EventParams['screen_name'];
+    firebase_screen: EventParams['firebase_screen'];
+    firebase_screen_class: EventParams['firebase_screen_class'];
     app_id?: string;
     app_version?: string;
     app_installer_id?: string;

packages-exp/analytics-exp/src/api.ts

@@ -279,6 +279,14 @@ export interface EventParams {
   number?: string;
   promotions?: Promotion[];
   screen_name?: string;
+  /**
+   * Firebase-specific. Use to log a `screen_name` to Firebase Analytics.
+   */
+  firebase_screen?: string;
+  /**
+   * Firebase-specific. Use to log a `screen_class` to Firebase Analytics.
+   */
+  firebase_screen_class?: string;
   search_term?: string;
   shipping?: Currency;
   tax?: Currency;

packages-exp/analytics-exp/src/public-types.ts

@@ -52,7 +52,8 @@ describe('client', () => {
   });
 
   it('returns a AppCheck token', async () => {
-    useFakeTimers();
+    // To get a consistent expireTime/issuedAtTime.
+    const clock = useFakeTimers();
     fetchStub.returns(
       Promise.resolve({
         status: 200,
@@ -77,6 +78,7 @@ describe('client', () => {
       expireTimeMillis: 3600,
       issuedAtTimeMillis: 0
     });
+    clock.restore();
   });
 
   it('throws when there is a network error', async () => {

packages-exp/app-check-exp/src/client.test.ts

@@ -24,6 +24,7 @@ import {
   removeTokenListener
 } from './internal-api';
 import { Provider } from '@firebase/component';
+import { getState } from './state';
 
 /**
  * AppCheck Service class.
@@ -34,6 +35,10 @@ export class AppCheckService implements AppCheck, _FirebaseService {
     public platformLoggerProvider: Provider<'platform-logger'>
   ) {}
   _delete(): Promise<void> {
+    const { tokenObservers } = getState(this.app);
+    for (const tokenObserver of tokenObservers) {
+      removeTokenListener(this.app, tokenObserver.next);
+    }
     return Promise.resolve();
   }
 }