Skip to content

Commit 8a0782e

Browse files
committed
build cjs correctly
1 parent 84456e5 commit 8a0782e

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

packages/webchannel-wrapper/gulpfile.js

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const closureDefines = [
6161
* @param {string} prefix prefix to the compiled code
6262
* @param {string} suffix suffix to the compiled code
6363
*/
64-
function createBuildTask(filename, prefix, suffix) {
64+
function createBuildTask(filename, prefix, suffix, languageout) {
6565
return function closureBuild() {
6666
return gulp
6767
.src(
@@ -83,7 +83,7 @@ function createBuildTask(filename, prefix, suffix) {
8383
resolve(__dirname, './externs/overrides.js'),
8484
resolve(__dirname, './externs/module.js')
8585
],
86-
language_out: 'ECMASCRIPT_2017',
86+
language_out: languageout,
8787
dependency_mode: 'PRUNE',
8888
define: closureDefines
8989
})
@@ -134,28 +134,27 @@ async function deleteIntermediateFiles() {
134134
await del('dist/temp');
135135
}
136136

137-
// Closure-generated ES2017 intermediate file (CJS format)
138-
const intermediateCjsFile = 'temp/cjs.js';
139-
const intermediateCjsPath = resolve(__dirname, 'dist/', intermediateCjsFile);
140-
const cjsBuild = createBuildTask(
141-
intermediateCjsFile,
142-
CJS_WRAPPER_PREFIX,
143-
CJS_WRAPPER_SUFFIX
144-
);
145-
146137
// Closure-generated ES2017 intermediate file (no wrapper text)
147138
const intermediateEsmFile = 'temp/esm.js';
148139
const intermediateEsmPath = resolve(__dirname, 'dist/', intermediateEsmFile);
149-
const esmBuild = createBuildTask(intermediateEsmFile, '', '');
140+
const esmBuild = createBuildTask(
141+
intermediateEsmFile,
142+
'',
143+
'',
144+
'ECMASCRIPT_2017'
145+
);
150146

151147
// cjs output
152-
const rollupCjsTask = createRollupTask({
153-
inputPath: intermediateCjsPath,
154-
outputExtension: '',
155-
compileToES5: true,
156-
format: 'cjs'
157-
});
158-
gulp.task('cjs', gulp.series(cjsBuild, rollupCjsTask));
148+
// Closure-generated ES5 CJS build
149+
const cjsBuildOutput = 'index.js';
150+
const cjsBuild = createBuildTask(
151+
cjsBuildOutput,
152+
CJS_WRAPPER_PREFIX,
153+
CJS_WRAPPER_SUFFIX,
154+
'ECMASCRIPT5'
155+
);
156+
157+
gulp.task('cjs', cjsBuild);
159158

160159
// esm intermediateEsmPath
161160
const rollupEsmTask = createRollupTask({

0 commit comments

Comments
 (0)