Skip to content

Commit 8b615ad

Browse files
schmidt-sebastianschmidt-sebastian
committed
Merge
2 parents eb13a86 + 1ef1341 commit 8b615ad

File tree

76 files changed

+798
-225
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+798
-225
lines changed

‎.changeset/big-otters-reply.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@firebase/firestore": patch
3+
"@firebase/storage": patch
4+
"@firebase/util": patch
5+
---
6+
7+
FirestoreError and StorageError now extend FirebaseError

‎.changeset/cuddly-birds-stare.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@firebase/auth-compat": patch
3+
"@firebase/auth": patch
4+
---
5+
6+
Fix persistence selection in compatibility layer in worker scripts

‎.changeset/plenty-trains-switch.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎.changeset/poor-files-learn.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎.changeset/red-actors-care.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎.github/CODEOWNERS

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434

3535
# These owners will be the default owners for everything in the repo.
36-
* @Feiyang1 @hiranya911 @hsubox76 @firebase/jssdk-global-approvers
36+
* @allspain @hsubox76 @firebase/jssdk-global-approvers
3737

3838
# Database Code
3939
packages/database @schmidt-sebastian @jsdt @firebase/jssdk-global-approvers
@@ -79,20 +79,20 @@ packages/performance-compat @jposuna @firebase/jssdk-global-approvers
7979
packages/performance-types @jposuna @firebase/jssdk-global-approvers
8080

8181
# Analytics Code
82-
packages/analytics @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
83-
packages/analytics-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
84-
packages/analytics-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
82+
packages/analytics @hsubox76 @firebase/jssdk-global-approvers
83+
packages/analytics-compat @hsubox76 @firebase/jssdk-global-approvers
84+
packages/analytics-types @hsubox76 @firebase/jssdk-global-approvers
8585

8686
# Remote Config Code
8787
packages/remote-config @erikeldridge @firebase/jssdk-global-approvers
8888
packages/remote-config-compat @erikeldridge @firebase/jssdk-global-approvers
8989
packages/remote-config-types @erikeldridge @firebase/jssdk-global-approvers
9090

9191
# App Check Code
92-
packages/app-check @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
93-
packages/app-check-compat @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
94-
packages/app-check-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
95-
packages/app-check-interop-types @hsubox76 @Feiyang1 @firebase/jssdk-global-approvers
92+
packages/app-check @hsubox76 @firebase/jssdk-global-approvers
93+
packages/app-check-compat @hsubox76 @firebase/jssdk-global-approvers
94+
packages/app-check-types @hsubox76 @firebase/jssdk-global-approvers
95+
packages/app-check-interop-types @hsubox76 @firebase/jssdk-global-approvers
9696

9797
# Documentation Changes
9898
packages/firebase/index.d.ts @egilmorez @firebase/jssdk-global-approvers

‎.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ assignees: ''
1111
<!-- Step 1 [READ THIS] -->
1212
<!--
1313
14+
**Thank you for submitting your issue. We are operating at reduced capacity from Dec 20 2021 to Jan 4 2022. While we are monitoring issues for major breakages and emergencies, there may be delayed responses. For more urgent requests please reach us via our support channels https://firebase.google.com/support**
15+
1416
Are you in the right place?
1517
* For issues or feature requests related to __the code in this repository__
1618
file a Github issue.

‎.github/workflows/e2e-test.yml

Lines changed: 56 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -19,57 +19,59 @@ jobs:
1919
working-directory: './e2e'
2020

2121
steps:
22-
- name: Checkout Repo
23-
uses: actions/checkout@master
24-
- name: Set up Node (12)
25-
uses: actions/setup-node@v2
26-
with:
27-
node-version: 12.x
28-
- name: install Chrome stable
29-
run: |
30-
sudo apt-get update
31-
sudo apt-get install google-chrome-stable
32-
- name: Bump Node memory limit
33-
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
34-
- name: Write project config
35-
env:
36-
PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }}
37-
TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
38-
run: |
39-
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
40-
- name: Yarn install
41-
run: |
42-
echo "Installing firebase@${{ github.event.inputs.versionOrTag }}"
43-
yarn add firebase@${{ github.event.inputs.versionOrTag }}
44-
yarn
45-
- name: Deploy "callTest" cloud function
46-
run: |
47-
pushd functions
48-
npm install
49-
popd
50-
npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
51-
working-directory: ./config
52-
env:
53-
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
54-
- name: Run modular tests
55-
env:
56-
APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
57-
run: xvfb-run yarn test:modular
58-
- name: Run compat tests
59-
env:
60-
APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
61-
run: xvfb-run yarn test:compat
62-
- name: Tests succeeded
63-
if: success()
64-
run: node scripts/ci/notify-test-result.js success
65-
env:
66-
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
67-
# run in root
68-
working-directory: '.'
69-
- name: Tests failed
70-
if: failure()
71-
run: node scripts/ci/notify-test-result.js fail
72-
env:
73-
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
74-
# run in root
75-
working-directory: '.'
22+
- name: Checkout Repo
23+
uses: actions/checkout@master
24+
- name: Set up Node (12)
25+
uses: actions/setup-node@v2
26+
with:
27+
node-version: 12.x
28+
- name: install Chrome stable
29+
run: |
30+
sudo apt-get update
31+
sudo apt-get install google-chrome-stable
32+
- name: Bump Node memory limit
33+
run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
34+
- name: Write project config
35+
env:
36+
PROJECT_CONFIG: ${{ secrets.TEST_PROJECT_CONFIG }}
37+
TEST_ACCOUNT: ${{ secrets.TEST_ACCOUNT }}
38+
run: |
39+
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
40+
- name: Yarn install
41+
run: |
42+
echo "Installing firebase@${{ github.event.inputs.versionOrTag }}"
43+
yarn add firebase@${{ github.event.inputs.versionOrTag }}
44+
yarn
45+
- name: Deploy "callTest" cloud function
46+
run: |
47+
pushd functions
48+
npm install
49+
popd
50+
npx firebase-tools deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
51+
working-directory: ./config
52+
env:
53+
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
54+
- name: Run modular tests
55+
env:
56+
APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
57+
run: xvfb-run yarn test:modular
58+
- name: Run compat tests
59+
env:
60+
APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
61+
run: xvfb-run yarn test:compat
62+
- name: Tests succeeded
63+
if: success()
64+
run: node scripts/ci/notify-test-result.js success
65+
env:
66+
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
67+
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
68+
# run in root
69+
working-directory: '.'
70+
- name: Tests failed
71+
if: failure()
72+
run: node scripts/ci/notify-test-result.js fail
73+
env:
74+
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
75+
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
76+
# run in root
77+
working-directory: '.'

‎.github/workflows/release-log.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,6 @@ jobs:
2020
node-version: 14.x
2121

2222
- name: Get PR number and send to tracker.
23-
run: node scripts/ci/log-changesets.js
23+
run: node scripts/ci/log-changesets.js
24+
env:
25+
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}

‎common/api-review/firestore-lite.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import { EmulatorMockTokenOptions } from '@firebase/util';
88
import { FirebaseApp } from '@firebase/app';
9+
import { FirebaseError } from '@firebase/util';
910
import { LogLevelString as LogLevel } from '@firebase/logger';
1011

1112
// @public
@@ -147,10 +148,9 @@ export interface FirestoreDataConverter<T> {
147148
}
148149

149150
// @public
150-
export class FirestoreError extends Error {
151+
export class FirestoreError extends FirebaseError {
151152
readonly code: FirestoreErrorCode;
152153
readonly message: string;
153-
readonly name: string;
154154
readonly stack?: string;
155155
}
156156

‎common/api-review/firestore.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import { EmulatorMockTokenOptions } from '@firebase/util';
88
import { FirebaseApp } from '@firebase/app';
9+
import { FirebaseError } from '@firebase/util';
910
import { LogLevelString as LogLevel } from '@firebase/logger';
1011

1112
// @public
@@ -177,10 +178,9 @@ export interface FirestoreDataConverter<T> {
177178
}
178179

179180
// @public
180-
export class FirestoreError extends Error {
181+
export class FirestoreError extends FirebaseError {
181182
readonly code: FirestoreErrorCode;
182183
readonly message: string;
183-
readonly name: string;
184184
readonly stack?: string;
185185
}
186186

‎integration/compat-interop/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
"test:debug": "karma start --browsers Chrome --auto-watch"
99
},
1010
"dependencies": {
11-
"@firebase/app": "0.7.10",
12-
"@firebase/app-compat": "0.1.11",
11+
"@firebase/app": "0.7.11",
12+
"@firebase/app-compat": "0.1.12",
1313
"@firebase/analytics": "0.7.4",
1414
"@firebase/analytics-compat": "0.1.5",
15-
"@firebase/auth": "0.19.3",
16-
"@firebase/auth-compat": "0.2.3",
15+
"@firebase/auth": "0.19.4",
16+
"@firebase/auth-compat": "0.2.4",
1717
"@firebase/functions": "0.7.6",
1818
"@firebase/functions-compat": "0.1.7",
1919
"@firebase/messaging": "0.9.4",

‎integration/firebase/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
88
},
99
"devDependencies": {
10-
"firebase": "9.6.0",
10+
"firebase": "9.6.1",
1111
"@types/chai": "4.2.22",
1212
"@types/mocha": "9.0.0",
1313
"chai": "4.3.4",

‎integration/firestore/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
1515
},
1616
"devDependencies": {
17-
"@firebase/app": "0.7.10",
18-
"@firebase/firestore-compat": "0.1.9",
17+
"@firebase/app": "0.7.11",
18+
"@firebase/firestore-compat": "0.1.10",
1919
"@types/mocha": "9.0.0",
2020
"gulp": "4.0.2",
2121
"gulp-filter": "7.0.0",

‎integration/messaging/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"test:manual": "mocha --exit"
1010
},
1111
"devDependencies": {
12-
"firebase": "9.6.0",
12+
"firebase": "9.6.1",
1313
"chai": "4.3.4",
1414
"chromedriver": "94.0.0",
1515
"express": "4.17.1",

‎packages/analytics-compat/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@firebase/app-compat": "0.x"
2424
},
2525
"devDependencies": {
26-
"@firebase/app-compat": "0.1.11",
26+
"@firebase/app-compat": "0.1.12",
2727
"rollup": "2.57.0",
2828
"@rollup/plugin-json": "4.1.0",
2929
"rollup-plugin-typescript2": "0.30.0",

‎packages/analytics/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
},
4848
"license": "Apache-2.0",
4949
"devDependencies": {
50-
"@firebase/app": "0.7.10",
50+
"@firebase/app": "0.7.11",
5151
"rollup": "2.57.0",
5252
"@rollup/plugin-commonjs": "21.0.0",
5353
"@rollup/plugin-json": "4.1.0",

‎packages/app-check-compat/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
},
4343
"license": "Apache-2.0",
4444
"devDependencies": {
45-
"@firebase/app-compat": "0.1.11",
45+
"@firebase/app-compat": "0.1.12",
4646
"rollup": "2.57.0",
4747
"@rollup/plugin-commonjs": "21.0.0",
4848
"@rollup/plugin-json": "4.1.0",

‎packages/app-check/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
},
4545
"license": "Apache-2.0",
4646
"devDependencies": {
47-
"@firebase/app": "0.7.10",
47+
"@firebase/app": "0.7.11",
4848
"rollup": "2.57.0",
4949
"@rollup/plugin-commonjs": "21.0.0",
5050
"@rollup/plugin-json": "4.1.0",

‎packages/app-compat/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# @firebase/app-compat
22

3+
## 0.1.12
4+
5+
### Patch Changes
6+
7+
- Updated dependencies []:
8+
- @firebase/app@0.7.11
9+
310
## 0.1.11
411

512
### Patch Changes

‎packages/app-compat/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/app-compat",
3-
"version": "0.1.11",
3+
"version": "0.1.12",
44
"description": "The primary entrypoint to the Firebase JS SDK",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",
@@ -39,7 +39,7 @@
3939
},
4040
"license": "Apache-2.0",
4141
"dependencies": {
42-
"@firebase/app": "0.7.10",
42+
"@firebase/app": "0.7.11",
4343
"@firebase/util": "1.4.2",
4444
"@firebase/logger": "0.3.2",
4545
"@firebase/component": "0.5.9",

‎packages/app/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# @firebase/app
22

3+
## 0.7.11
4+
5+
### Patch Changes
6+
7+
- Update SDK_VERSION.
8+
39
## 0.7.10
410

511
### Patch Changes

‎packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/app",
3-
"version": "0.7.10",
3+
"version": "0.7.11",
44
"description": "The primary entrypoint to the Firebase JS SDK",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",

‎packages/auth-compat/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# @firebase/auth-compat
22

3+
## 0.2.4
4+
5+
### Patch Changes
6+
7+
- Updated dependencies [[`a777385d6`](https://github.com/firebase/firebase-js-sdk/commit/a777385d67653cdcc3b839149dde867f32b48369), [`dc6b447ba`](https://github.com/firebase/firebase-js-sdk/commit/dc6b447bac4e899a0c4741ec18bf19e2ae66731a)]:
8+
- @firebase/auth@0.19.4
9+
310
## 0.2.3
411

512
### Patch Changes

0 commit comments

Comments
 (0)