Skip to content

Commit 8bbcdb9

Browse files
committed
Make 2 different error messages
1 parent 92bf2c3 commit 8bbcdb9

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

packages/analytics/index.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
getFakeInstallations
3131
} from './testing/get-fake-firebase-services';
3232
import { FirebaseApp } from '@firebase/app-types';
33-
import { GtagCommand, EventName, GA_FID_KEY } from './src/constants';
33+
import { GtagCommand, EventName } from './src/constants';
3434
import { findGtagScriptOnPage } from './src/helpers';
3535
import { removeGtagScript } from './testing/gtag-script-util';
3636
import { Deferred } from '@firebase/util';
@@ -248,7 +248,7 @@ describe('FirebaseAnalytics instance tests', () => {
248248
origin: 'firebase'
249249
});
250250
expect(warnStub.args[0][1]).to.include(
251-
AnalyticsError.INVALID_ANALYTICS_CONTEXT
251+
AnalyticsError.INDEXEDDB_UNAVAILABLE
252252
);
253253
expect(warnStub.args[0][1]).to.include('IndexedDB is not available');
254254
idbStub.restore();
@@ -268,7 +268,7 @@ describe('FirebaseAnalytics instance tests', () => {
268268
origin: 'firebase'
269269
});
270270
expect(warnStub.args[0][1]).to.include(
271-
AnalyticsError.INVALID_ANALYTICS_CONTEXT
271+
AnalyticsError.INDEXEDDB_UNAVAILABLE
272272
);
273273
expect(warnStub.args[0][1]).to.include('idb open error test');
274274
});

packages/analytics/src/errors.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export const enum AnalyticsError {
2222
ALREADY_INITIALIZED = 'already-initialized',
2323
INTEROP_COMPONENT_REG_FAILED = 'interop-component-reg-failed',
2424
INVALID_ANALYTICS_CONTEXT = 'invalid-analytics-context',
25+
INDEXEDDB_UNAVAILABLE = 'indexeddb-unavailable',
2526
FETCH_THROTTLE = 'fetch-throttle',
2627
CONFIG_FETCH_FAILED = 'config-fetch-failed',
2728
NO_API_KEY = 'no-api-key',
@@ -43,6 +44,10 @@ const ERRORS: ErrorMap<AnalyticsError> = {
4344
'Firebase Analytics is not supported in this environment. ' +
4445
'Wrap initialization of analytics in analytics.isSupported() ' +
4546
'to prevent initialization in unsupported environments. Details: {$errorInfo}',
47+
[AnalyticsError.INDEXEDDB_UNAVAILABLE]:
48+
'IndexedDB unavailable or restricted in this environment. ' +
49+
'Wrap initialization of analytics in analytics.isSupported() ' +
50+
'to prevent initialization in unsupported environments. Details: {$errorInfo}',
4651
[AnalyticsError.FETCH_THROTTLE]:
4752
'The config fetch request timed out while in an exponential backoff state.' +
4853
' Unix timestamp in milliseconds when fetch request throttling ends: {$throttleEndTimeMillis}.',
@@ -65,6 +70,7 @@ interface ErrorParams {
6570
responseMessage: string;
6671
};
6772
[AnalyticsError.INVALID_ANALYTICS_CONTEXT]: { errorInfo: string };
73+
[AnalyticsError.INDEXEDDB_UNAVAILABLE]: { errorInfo: string };
6874
}
6975

7076
export const ERROR_FACTORY = new ErrorFactory<AnalyticsError, ErrorParams>(

packages/analytics/src/initialize-ids.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import { ERROR_FACTORY, AnalyticsError } from './errors';
3434
async function validateIndexedDB(): Promise<boolean> {
3535
if (!isIndexedDBAvailable()) {
3636
logger.warn(
37-
ERROR_FACTORY.create(AnalyticsError.INVALID_ANALYTICS_CONTEXT, {
37+
ERROR_FACTORY.create(AnalyticsError.INDEXEDDB_UNAVAILABLE, {
3838
errorInfo: 'IndexedDB is not available in this environment.'
3939
}).message
4040
);
@@ -44,7 +44,7 @@ async function validateIndexedDB(): Promise<boolean> {
4444
await validateIndexedDBOpenable();
4545
} catch (e) {
4646
logger.warn(
47-
ERROR_FACTORY.create(AnalyticsError.INVALID_ANALYTICS_CONTEXT, {
47+
ERROR_FACTORY.create(AnalyticsError.INDEXEDDB_UNAVAILABLE, {
4848
errorInfo: e
4949
}).message
5050
);

0 commit comments

Comments
 (0)